Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mysql-cdc): fix mysql enum type default value #19192

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented Oct 30, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title. And for unexpected default value, we just set to null instead of throw errors during CREATE TABLE.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@StrikeW StrikeW marked this pull request as ready for review October 30, 2024 07:27
@StrikeW StrikeW changed the title fix(mysql-cdc): fix enum default value fix(mysql-cdc): fix mysql enum type default value Oct 30, 2024
@graphite-app graphite-app bot requested a review from a team October 30, 2024 08:05
@StrikeW StrikeW added this pull request to the merge queue Nov 2, 2024
Merged via the queue into main with commit 3a8d5a8 Nov 2, 2024
54 of 55 checks passed
@StrikeW StrikeW deleted the siyuan/mysql-cdc-default branch November 2, 2024 05:03
github-merge-queue bot pushed a commit that referenced this pull request Nov 2, 2024
Co-authored-by: StrikeW <wangsiyuanse@gmail.com>
github-merge-queue bot pushed a commit that referenced this pull request Nov 2, 2024
Co-authored-by: StrikeW <wangsiyuanse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants