Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch): support system column _rw_timestamp for tables #19232

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Nov 1, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Resolve Add system column rw_timestamp for any tables #11629
  • Support system column _rw_timestamp (datatype is timestamptz) for tables. We will add a hidden column _rw_timestamp to every table catalog when loading it from a proto, but we never persist this column info.
  • Only support selecting _rw_timestamp in a batch query. Using it in a streaming query will cause an error.
  • For batch batch queries, we add a field epoch_idx to the storage table which indicates the position where we should put the epoch into.
  • Since the state store get_row interface doesn't expose any epoch information, we will use the iter interface to support point get if _rw_timestamp is selected.
  • Lots of change is caused by planner tests, the core change is about 200+ LOC.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

  • Support _rw_timestamp system column for tables. Users can use a batch query to select this column to check the internal epoch/timestamp of each row which is useful when you want to know when the rows have been updated recently.

@chenzl25 chenzl25 added the user-facing-changes Contains changes that are visible to users label Nov 1, 2024
@graphite-app graphite-app bot requested a review from a team November 1, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add system column rw_timestamp for any tables
1 participant