Fix compiler warnings gnu/arc*.c syscall.c print.c debug_gdb.c #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wargio
requested review from
kazarmy,
ret2libc,
thestr4ng3r and
XVilka
as code owners
wargio
changed the title
XVilka
reviewed
Jun 20, 2021
| @@ -86,8 +86,9 @@ typedef enum | |||
| #define PUT_NEXT_WORD_IN(a) \ | |||
| do \ | |||
| { \ | |||
| if (is_limm == 1 && !NEXT_WORD (1)) \ | |||
| if (is_limm == 1 && !NEXT_WORD (1)) { \ | |||
There was a problem hiding this comment.
Please note, that this file is copied from binutils:
| @@ -99,8 +99,9 @@ static bfd_vma bfd_getm32_ac (unsigned int) ATTRIBUTE_UNUSED; | |||
| #define FIELDS9_FLAG(word) (((BITS(((signed int)(word)),0,5) << 6) | (BITS((word),6,11))) ) | |||
|
|
|||
| #define PUT_NEXT_WORD_IN(a) { \ | |||
| if (is_limm==1 && !NEXT_WORD(1)) \ | |||
| mwerror(state, "Illegal limm reference in last instruction!\n"); \ | |||
| if (is_limm==1 && !NEXT_WORD(1)) { \ | |||
officialcjunior
approved these changes
Jun 20, 2021
yossizap
approved these changes
Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQUASH ME
Your checklist for this pull request
Detailed description
Resolves the NULL format warnings and a leak in rz_syscall