Capstone@next TriCore #3463

imbillow · 2023-04-17T02:35:44Z

REBASE ONLY

Your checklist for this pull request

I've read the guidelines for contributing to this repository
I made sure to follow the project's coding style
I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
I've added tests that prove my fix is effective or that my feature works (if possible)
I've updated the rizin book with the relevant information (if needed)

Detailed description

Update TriCore asm plugin
Improve TriCore analysis plugin

Test plan

CI is green

Closing issues

Partially addresses #2704
Closes #3540

XVilka · 2023-04-20T01:51:14Z

@imbillow you could temporarily disable it in your PR, and address them later

imbillow · 2023-06-06T16:32:53Z

I found that there are some variables with different names and types in the DWARF information but with the same location. What I do in the code is to let it do not overwrite the arguments of function at least.

XVilka · 2023-06-07T02:18:19Z

I found that there are some variables with different names and types in the DWARF information but with the same location. What I do in the code is to let it do not overwrite the arguments of function at least.

Interesting. This is better be addressed during the DWARF 5 implementation though. Since the only issue in this PR is the System Z, could you please extract variable changes (after addressing my feedback first) into a separate PR again, so that we could merge them again and rebase tricore branches?

XVilka · 2023-06-07T02:50:03Z

One more nitpick @imbillow, on the same file erika3app.elf:

[0x80000020]> afv @ dbg.osEE_alarm_get
var OsEE_CounterDB *p_counter_db @ a12
var OsEE_TriggerCB * const  p_trigger_cb @ a13
var OsEE_spin_lock *p_lock @ a15
var OsEE_CDB * const  p_cdb @ a2
arg OsEE_AlarmDB *p_alarm_db @ a4
var CoreIdType counter_core_id @ d10
arg TickType *p_tick @ d11
var TickType delta @ d15
var TickType when @ d2
var StatusType ev @ d8

Note the * const and then two spaces before p_cdb. I think it should be var OsEE_CDB *const p_cdb @ a2 instead, and for other similar cases.

Please also rebase on top of the latest dev

XVilka

Why do you try to fix it as the endianness of the Tricore? It's the endianness of the host. I think the bug is somewhere in the Capstone, and you could try just running capstone tests for Tricore on the System Z VM, I bet it will show the problem

imbillow · 2023-06-07T13:16:46Z

Why do you try to fix it as the endianness of the Tricore? It's the endianness of the host. I think the bug is somewhere in the Capstone, and you could try just running capstone tests for Tricore on the System Z VM, I bet it will show the problem

Just trying it out.

I've actually tried debug in a s390x qemu Ubuntu22.04 VM, but found that gdb/lldb doesn't seem to debug properly.

I'll do more experimentation when I can operate my pc later.

XVilka

Looks green now; well done. Please rearrange commits, and extract non-tricore part into a separate PR. Once its merged, we can rebase and merge this one too.

XVilka · 2023-06-08T00:46:23Z

librz/core/canalysis.c

@@ -6466,3 +6466,43 @@ RZ_API void rz_core_perform_auto_analysis(RZ_NONNULL RzCore *core, RzCoreAnalysi
 	rz_cons_break_pop();
 	RZ_FREE(debugger);
 }
+
+RZ_API char *rz_core_analysis_var_to_string(RZ_NONNULL RzCore *core, RZ_NONNULL RzAnalysisVar *var) {


@imbillow you forgot this

XVilka · 2023-06-08T00:47:03Z

librz/include/rz_core.h

@@ -1281,6 +1281,8 @@ RZ_API RZ_OWN RzList /*<RzRegItem *>*/ *rz_core_reg_filter_items_sync(RZ_NONNULL
 RZ_API void rz_core_cmd_show_analysis_help(RZ_NONNULL RzCore *core);
 RZ_API void rz_core_rtr_enable(RZ_NONNULL RzCore *core, const char *cmdremote);

+RZ_API char *rz_core_analysis_var_to_string(RZ_NONNULL RzCore *core, RZ_NONNULL RzAnalysisVar *var);


imbillow · 2023-06-08T05:19:44Z

#3561

I will fix these places in a new PR

XVilka · 2023-06-08T09:23:08Z

@imbillow merged the PR: 6f3969f

Please rebase capstone-ng and this PR on top of dev, then we can finally merge this.

github-actions bot added documentation Improvements or additions to documentation infrastructure rz-test labels Apr 17, 2023

This comment was marked as resolved.

Sign in to view

github-actions bot added the RzAsm-Disassembler label Apr 20, 2023

imbillow force-pushed the capstone-tricore branch from 5184edb to 79f9726 Compare April 20, 2023 01:27

This comment was marked as resolved.

Sign in to view

github-actions bot added the RzAnalysis label Apr 20, 2023

imbillow force-pushed the capstone-tricore branch from 076dda9 to 6a44426 Compare April 20, 2023 13:10

github-actions bot added the API label Apr 20, 2023

XVilka added this to the 0.6.0 milestone Apr 23, 2023

XVilka mentioned this pull request Apr 23, 2023

Evm support #3368

Closed

5 tasks

imbillow force-pushed the capstone-tricore branch from 649f785 to d0926df Compare April 23, 2023 06:24

imbillow mentioned this pull request Apr 23, 2023

RzIL TriCore Support #3478

Merged

5 tasks

This comment was marked as resolved.

Sign in to view

This was referenced May 5, 2023

Rewrite GPL-only code #2704

Open

Support Tricore rizinorg/rz-ghidra#319

Open

This comment was marked as resolved.

Sign in to view

imbillow force-pushed the capstone-tricore branch from 8b4c418 to f719ba5 Compare May 10, 2023 07:50

This comment was marked as resolved.

Sign in to view

github-actions bot added the RzDebug label May 10, 2023

XVilka mentioned this pull request Jun 7, 2023

Missing argument in ARMv7 function derived from DWARF #3548

Closed

XVilka requested changes Jun 7, 2023

View reviewed changes

This comment was marked as off-topic.

Sign in to view

imbillow force-pushed the capstone-tricore branch from c28fe4b to ae6561d Compare June 7, 2023 18:29

XVilka requested changes Jun 8, 2023

View reviewed changes

XVilka mentioned this pull request Jun 8, 2023

ARMv7 failure to load register arguments when subroutine uses CFA #3562

Open

yossizap and others added 9 commits June 8, 2023 17:35

Set the default capstone version to v5 instead of v4

218725f

Update capstone versions in the docs

de9e736

Update capstone instruction ids

ad58c63

Updated capstone project url and capstone-next commit

9aefbb1

Removing GNU tricore analysis and asm plugin

0a3c195

Adding new cs-based tricore analysis and asm plugin

6f69689

Fixes capstone update

1cffe51

Masking BROKEN tests by the cs update

0e819c7

Update tests by cs update and tricore

81c8b16

imbillow force-pushed the capstone-tricore branch from ae6561d to 81c8b16 Compare June 8, 2023 09:44

github-actions bot removed RzCore GDB DWARF RzUtil RzDebug labels Jun 8, 2023

XVilka added the merge-when-green label Jun 8, 2023

XVilka merged commit 01ea5d6 into capstone-ng Jun 8, 2023

XVilka deleted the capstone-tricore branch June 8, 2023 11:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Capstone@next TriCore #3463

Capstone@next TriCore #3463

imbillow commented Apr 17, 2023 •

edited by XVilka

Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

XVilka commented Apr 20, 2023

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

imbillow commented Jun 6, 2023 •

edited

Loading

XVilka commented Jun 7, 2023 •

edited

Loading

XVilka commented Jun 7, 2023 •

edited

Loading

XVilka left a comment

imbillow commented Jun 7, 2023

This comment was marked as off-topic.

XVilka left a comment

XVilka Jun 8, 2023

XVilka Jun 8, 2023

imbillow commented Jun 8, 2023

XVilka commented Jun 8, 2023

Capstone@next TriCore #3463

Capstone@next TriCore #3463

Conversation

imbillow commented Apr 17, 2023 • edited by XVilka Loading

REBASE ONLY

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

XVilka commented Apr 20, 2023

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

imbillow commented Jun 6, 2023 • edited Loading

XVilka commented Jun 7, 2023 • edited Loading

XVilka commented Jun 7, 2023 • edited Loading

XVilka left a comment

Choose a reason for hiding this comment

imbillow commented Jun 7, 2023

This comment was marked as off-topic.

XVilka left a comment

Choose a reason for hiding this comment

XVilka Jun 8, 2023

Choose a reason for hiding this comment

XVilka Jun 8, 2023

Choose a reason for hiding this comment

imbillow commented Jun 8, 2023

XVilka commented Jun 8, 2023

imbillow commented Apr 17, 2023 •

edited by XVilka

Loading

imbillow commented Jun 6, 2023 •

edited

Loading

XVilka commented Jun 7, 2023 •

edited

Loading

XVilka commented Jun 7, 2023 •

edited

Loading