Types: add more missing atomic types and fix structure format size calculation #4624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVilka
force-pushed
the
asan-type-atomics
branch
3 times, most recently
from
a2a9b51
to
56f10b8
Compare
XVilka
requested review from
kazarmy,
thestr4ng3r and
ret2libc
as code owners
XVilka
force-pushed
the
asan-type-atomics
branch
from
56f10b8
to
466574d
Compare
XVilka
force-pushed
the
asan-type-atomics
branch
from
466574d
to
061814e
Compare
Rot127
requested changes
Sep 9, 2024
| uint16_t=type | ||
| type.uint16_t=w | ||
| type.uint16_t.size=16 | ||
| type.uint16_t.typeclass=Unsigned Integral | ||
|
|
||
| uint_fast16_t=type | ||
| type.uint_fast16_t=w |
There was a problem hiding this comment.
w for word? Isn't this again architecture specific if it is a word or half-word? Also below with potentially w = 32bit, d == 64bit, q == 128bit
There was a problem hiding this comment.
Couldn't find anything in the C standard (looked briefly). But I find 16 = halfword more intuitive nowadays. The bit-widths don't get smaller in the end.
There was a problem hiding this comment.
It's how it's defined in the pf, see the pf?:
Formats:
| b # byte (unsigned)
| B # resolve enum bitfield (see t?)
| c # char (signed byte)
| C # byte in decimal
| d # 0xHEX value (4 bytes) (see 'i' and 'x' formats)
| D # disassemble one opcode
| e # temporarily swap endian
| E # resolve enum name (see t?)
| f # float value (4 bytes)
| F # double float value (8 bytes)
| i # signed integer value (4 bytes) (see 'd' and 'x' formats)
| n # next char specifies size of signed value (1, 2, 4, or 8 byte(s))
| N # next char specifies size of unsigned value (1, 2, 4, or 8 byte(s))
| o # octal value (4 bytes)
| p # pointer reference (2, 4, or 8 bytes)
| q # quadword (8 bytes)
| Q # octoword (uint128_t) (16 bytes)
| r # CPU register (`pf r (eax)plop`)
| s # 32 bit pointer to string (4 bytes)
| s # 32 bit pointer to string (4 bytes)
| t # 32 bit UNIX timestamp (4 bytes)
| T # show ten first bytes of buffer
| u # uleb128 (variable length)
| w # word (2 bytes unsigned short in hex)
| @@ -1682,7 +1688,7 @@ RZ_API int rz_type_format_struct_size(const RzTypeDB *typedb, const char *f, int | |||
| free(o); | |||
| return 0; | |||
| } | |||
| int newsize = rz_type_format_struct_size(typedb, format, mode, n + 1); | |||
| int newsize = format_struct_size(typedb, f, format, mode, depth + 1); | |||
There was a problem hiding this comment.
Rename f to something descriptive.
There was a problem hiding this comment.
I can't because it would require renaming in many places, I try to keep changes in the formatting code to the minimum.
wargio
reviewed
Sep 9, 2024
wargio
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
After testing Rizin on some firmwares I found these two problems:
Test plan
CI is green