Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Xtensa arch support #4654

Merged
merged 29 commits into from
Nov 10, 2024
Merged

Add Xtensa arch support #4654

merged 29 commits into from
Nov 10, 2024

Conversation

imbillow
Copy link
Contributor

@imbillow imbillow commented Sep 28, 2024 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

...

@XVilka XVilka mentioned this pull request Sep 29, 2024
Open
10 tasks
@imbillow imbillow force-pushed the xtensa-support branch 3 times, most recently from 59c467b to f970b38 Compare October 3, 2024 00:03
@XVilka
Copy link
Member

XVilka commented Oct 6, 2024

Probably makes sense to rebase on top of the #4662 to avoid conflicts and double work. cc @Rot127

@Rot127
Copy link
Member

Rot127 commented Oct 7, 2024

Yes, though let's wait until the Capstone PRs are merged.

@imbillow imbillow marked this pull request as ready for review November 5, 2024 13:56
@XVilka XVilka mentioned this pull request Nov 5, 2024
Open
6 tasks
XVilka
XVilka requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the ESIL file since I hope we remove it soon. As long as it doesn't break anything, everything is fine in that file.

librz/arch/p/analysis/analysis_xtensa_cs.c Outdated Show resolved Hide resolved
librz/arch/p/analysis/analysis_xtensa_cs.c Outdated Show resolved Hide resolved
test/db/analysis/xtensa Outdated Show resolved Hide resolved
test/db/cmd/cmd_list Outdated Show resolved Hide resolved
librz/arch/isa/xtensa/xtensa.c Outdated Show resolved Hide resolved
librz/arch/isa/xtensa/xtensa.h Outdated Show resolved Hide resolved
XVilka

This comment was marked as resolved.

Sign in to view

@XVilka
Copy link
Member

XVilka commented Nov 6, 2024

OK, LGTM now, just lets wait first for the Capstone PR to be merged first.

Rot127
Rot127 requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Just those few things and it lgtm.

librz/arch/p/analysis/analysis_xtensa_cs.c Show resolved Hide resolved
librz/arch/p/analysis/analysis_xtensa_cs.c Outdated Show resolved Hide resolved
@XVilka XVilka merged commit c3c494d into dev Nov 10, 2024
46 of 47 checks passed
@XVilka XVilka deleted the xtensa-support branch November 10, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka requested changes

@Rot127 Rot127 Rot127 approved these changes

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
merge-when-green rz-test RzAnalysis RzAsm-Disassembler RzCore Xtensa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imbillow @XVilka @Rot127