Fix #255: Replace deeper dependency with local deepEquals helper. #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1k0
force-pushed
the
custom-deep-eq-checks
branch
from
7dd16ac
to
71f86d3
Compare
|
Released in v0.36.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes our dependency to deeper, introduces a new
deepEqualsutil leveraging part of its implementation and tweaks the comparison alg. to whitelist functions, so that solves #255 as well.We had troubles with deeper in the past, and the project doesn't seem to move forward anymore (see this PR which has not even received a comment in 3 months), so I think now is a good time to move to something else more immediately suited to our needs.