-
-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save time data to element #110
base: master
Are you sure you want to change the base?
Conversation
This looks like it breaks the automatic refreshing of fuzzy timestamps values as time passes each minute. |
I believe you're right, as those values are only calculated on the initial creation. |
I thought I had fixed it, but I had not. I was looking at the wrong version. Sorry about the confusion. I'll continue looking at this, but at this point, it's still broken. |
Just wanted to let you know this is working for us now in case you were interested in it. If not, feel free to close! Thanks for this awesome plugin! It's been a huge help! |
@smizell Oh. So sorry. I missed the extra code commit come through. I'll take a peek as soon as I get a chance. Thanks for the nudge. |
No problem at all. I wasn't really for sure if you got notified when I did a commit, so I wanted to followup in case. I also corrected a small mistake where I did not use var with a variable. I just noticed it. Thanks! |
I was needing to use the time data from this plugin for other calculations, and since it had already calculated seconds, hours, days, and years, I exposed that data along with the
datetime
inelement.data('timeago')
. I figured this was better since it was not doing all of those calculations over again.With this, you can access the data like this (example):
This also updates the tests.