Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema::Subset: Don't build schema caches, sort directives in introspection #5039

Merged
merged 8 commits into from
Jul 26, 2024

Conversation

rmosolgo
Copy link
Owner

@rmosolgo rmosolgo commented Jul 24, 2024

To support lazy-loading types, this turns off eager-loading when Schema::Subset is enabled.

Part of #5014 and #4919

TODO:

  • Document: Schema.from_definition used to retain unreferenced types, but it doesn't anymore.
  • Run benchmarks vs master to make sure this doesn't introduce problematic latency. (I don't expect so -- the calls to Schema. methods are only called once per type per query.)
    • Memory usage was identical, runtime was within margin of error

@rmosolgo rmosolgo changed the title Schema::Subset: Don't build schema caches Schema::Subset: Don't build schema caches, sort directives in introspection Jul 25, 2024
@rmosolgo rmosolgo added this to the 2.3.11 milestone Jul 26, 2024
@rmosolgo rmosolgo merged commit 730d732 into master Jul 26, 2024
14 checks passed
@rmosolgo rmosolgo deleted the run-without-schema-caches branch October 8, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant