Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: bank details #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MartinSchobben
Copy link

Hi Robert - I was wondering whether it would be possible to have an option to include bank details as a footer to the letter. I am working on a project where I want to generate invoices with komaletter. Besides changes to the resource files, I included an example (example 5) that shows creating an invoice. I can change the content of the example to just an markdown table, so that you don't have to rely on my work-in-progress remote. Or I can completely delete it. For now, it is just to demonstrate my use case.

@rnuske
Copy link
Owner

rnuske commented Oct 25, 2021

Hi Martin,
thanks for your contribution. I am always happy if people use this package and even more so if there are enhancements coming back ;-) I was on vacation for the last week and am just catching up. Will have a closer look at your pull request in the next days.
I'd like to make sure that the layout doesn't change without bank details due to the added footer on the first page. I am a fan of minimal dependencies and would prefer not to add a dependency just for an example. Could you create an example without the additional package and perhaps mention the convenience of using bookkeeper in the text of the example letter?

@MartinSchobben
Copy link
Author

Sure, I understand. I removed the dependency. I left the reference to the bookkeeper package in the example's markdown chunk (but it's not evaluated). I do not want to draw too much attention to the usage of bookkeeper, which is a concept at best. I hope the proposed change does not alter the layout. Thanks for considering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants