Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for "google/common-protos" v4.0 #24

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

butschster
Copy link
Contributor

Updated the package to support both "google/common-protos" version ^3.1 and ^4.0. This provides users with the flexibility to choose between the two major releases while ensuring backward compatibility.

Q A
Breaks BC?
Issues roadrunner-php/issues#25

Updated the package to support both "google/common-protos" version ^3.1 and ^4.0. This provides users with the flexibility to choose between the two major releases while ensuring backward compatibility.
@butschster butschster added the enhancement New feature or request label Oct 25, 2023
@butschster butschster self-assigned this Oct 25, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69ae07b) 76.58% compared to head (254b176) 76.58%.
Report is 1 commits behind head on 3.x.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                3.x      #24   +/-   ##
=========================================
  Coverage     76.58%   76.58%           
  Complexity       94       94           
=========================================
  Files             8        8           
  Lines           252      252           
=========================================
  Hits            193      193           
  Misses           59       59           
Files Coverage Δ
src/Method.php 74.69% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster merged commit 94b5ec7 into 3.x Oct 26, 2023
3 checks passed
@butschster butschster deleted the feature/25 branch October 26, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🧹 CHORE]: Upgrade google/common-protos in roadrunner-php/grpc
4 participants