Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for collaboration experiment #254

Merged
merged 25 commits into from
Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
a404fa4
gitignore update
xBambusekD May 16, 2022
1d320c5
TextMesh Pro removed - should be located in Submodules, not indexed i…
xBambusekD May 16, 2022
dccd2b2
fix: RosSharp updated - STL rotation fix
xBambusekD May 16, 2022
e6e846e
Merge branch 'master' of https://github.com/robofit/arcor2_editor int…
xBambusekD Jul 27, 2022
5b64304
feat: VR mode joystick speed and size adjusted.
xBambusekD Jul 28, 2022
6091609
changes before merge
xBambusekD Mar 13, 2023
335b80e
Merge branch 'master' of https://github.com/robofit/arcor2_editor int…
xBambusekD Mar 15, 2023
aa520a5
feat: Start and End action temporarily moved to sides of the table
xBambusekD Feb 21, 2024
413a3f3
commit before merge
xBambusekD Feb 21, 2024
b701168
Merge branch 'devel'
xBambusekD Feb 21, 2024
5305d7c
feat: Rename of AP or Actions automatically replaces whitespace with …
xBambusekD Feb 21, 2024
00921c6
fix: Automatic recalibration is called correctly after the user-defin…
xBambusekD Feb 21, 2024
7b93b51
feat: Stepping menu of the EE can be opened just by targeting the rob…
xBambusekD Feb 21, 2024
5bf8c19
fix: VR mode merge fix
xBambusekD Feb 21, 2024
8de8c94
fix: VR mode merge
xBambusekD Feb 21, 2024
1c9c002
fix: VR mode nullreference error, MainSettingsMenu - the default sele…
xBambusekD Feb 22, 2024
71072db
fix: Action stayed locked after no connection selected.
xBambusekD Feb 22, 2024
dd3685f
fix: all AP grayed out when other user intiated renaming of the AP
xBambusekD Feb 23, 2024
1fcd792
fix: Robot EE automatically selected just by targetting it with curso…
xBambusekD Feb 23, 2024
259d781
Merge branch 'master' of https://github.com/robofit/arcor2_editor
xBambusekD Mar 18, 2024
909795c
fix: default speed of the robot in the stepping menu increased to 0.9
xBambusekD Mar 25, 2024
0ac4e05
fix: models updated (previous version was missing some local changes)
xBambusekD Mar 26, 2024
051efe3
chore: removed unnecessary debug logs
xBambusekD Mar 26, 2024
77924b4
chore: missing meta file added
xBambusekD Mar 26, 2024
888d380
fix: Connection selector dialog title and cancel button fixed
xBambusekD Mar 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
[Mm]emoryCaptures/
/arcor2_AREditor/[Uu]ser[Ss]ettings/
/arcor2_AREditor/[Aa]ssets/[Ss]ubmodules*
/arcor2_AREditor/Assets/ExtensionsAssets/
/arcor2_AREditor/[Aa]ssets/[Pp]lugins*
/arcor2_AREditor/[Pp]ackages*

# Never ignore Asset meta data
!/[Aa]ssets/**/*.meta
Expand Down
9 changes: 5 additions & 4 deletions arcor2_AREditor/Assets/BASE/Scripts/Action.cs
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,11 @@ private void ShowOutputTypeDialog(UnityAction callback)

private async Task CreateNewConnection()
{

if (!await WriteLock(false)) {
return;
}

ConnectionManagerArcoro.Instance.CreateConnectionToPointer(Output.gameObject);

await GameManager.Instance.RequestObject(GameManager.EditorStateEnum.SelectingAction, GetOtherAction,
Expand Down Expand Up @@ -325,10 +330,6 @@ public async Task SelectedConnection(LogicItem logicItem)
GameManager.Instance.ShowLoadingScreen("Removing old connection...");
await WebsocketManager.Instance.RemoveLogicItem(logicItem.Data.Id);
GameManager.Instance.HideLoadingScreen();
if (!await otherAction.WriteLock(false))
{
return;
}
AddConnection();

}
Expand Down
2 changes: 1 addition & 1 deletion arcor2_AREditor/Assets/BASE/Scripts/EndAction.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public override void Init(IO.Swagger.Model.Action projectAction, Base.ActionMeta
parameters: new List<IO.Swagger.Model.ActionParameter>(),
type: "");
base.Init(prAction, metadata, ap, actionProvider, keySuffix);
transform.localPosition = PlayerPrefsHelper.LoadVector3(playerPrefsKey, new Vector3(0, 0.1f, 0));
transform.localPosition = PlayerPrefsHelper.LoadVector3(playerPrefsKey, new Vector3(0, 0.1f, 0.6f));
//Input.SelectorItem = SelectorMenu.Instance.CreateSelectorItem(Input);
}

Expand Down
2 changes: 2 additions & 0 deletions arcor2_AREditor/Assets/BASE/Scripts/LockingEventsCache.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ public class LockingEventsCache : Singleton<LockingEventsCache> {
/// Invoked when an object is locked or unlocked
/// </summary>
public event AREditorEventArgs.ObjectLockingEventHandler OnObjectLockingEvent;
public event AREditorEventArgs.StringEventHandler OnAfterObjectLockingEvent;
private bool canInvoke = false;
private bool wasAppKilled = true;
private bool arOn = false;
Expand Down Expand Up @@ -69,6 +70,7 @@ public void Add(ObjectLockingEventArgs objectsLockingEvent) {
}
}
InvokeEvents();
OnAfterObjectLockingEvent?.Invoke(this, new StringEventArgs(""));
}


Expand Down
2 changes: 1 addition & 1 deletion arcor2_AREditor/Assets/BASE/Scripts/StartAction.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public override void Init(IO.Swagger.Model.Action projectAction, Base.ActionMeta
parameters: new List<IO.Swagger.Model.ActionParameter>(),
type: "");
base.Init(prAction, metadata, ap, actionProvider, actionType);
transform.localPosition = PlayerPrefsHelper.LoadVector3(playerPrefsKey, new Vector3(0, 0.15f, 0));
transform.localPosition = PlayerPrefsHelper.LoadVector3(playerPrefsKey, new Vector3(0, 0.15f, -0.6f));
// Output.SelectorItem = SelectorMenu.Instance.CreateSelectorItem(Output);
}

Expand Down
10 changes: 8 additions & 2 deletions arcor2_AREditor/Assets/TABLET/Materials/ActionPointMaterial.mat
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,24 @@
%TAG !u! tag:unity3d.com,2011:
--- !u!21 &2100000
Material:
serializedVersion: 6
serializedVersion: 8
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_Name: ActionPointMaterial
m_Shader: {fileID: 46, guid: 0000000000000000f000000000000000, type: 0}
m_ShaderKeywords:
m_Parent: {fileID: 0}
m_ModifiedSerializedProperties: 0
m_ValidKeywords: []
m_InvalidKeywords: []
m_LightmapFlags: 4
m_EnableInstancingVariants: 0
m_DoubleSidedGI: 0
m_CustomRenderQueue: -1
stringTagMap: {}
disabledShaderPasses: []
m_LockedProperties:
m_SavedProperties:
serializedVersion: 3
m_TexEnvs:
Expand Down Expand Up @@ -55,6 +59,7 @@ Material:
m_Texture: {fileID: 0}
m_Scale: {x: 1, y: 1}
m_Offset: {x: 0, y: 0}
m_Ints: []
m_Floats:
- _BumpScale: 1
- _Cutoff: 0.5
Expand All @@ -75,3 +80,4 @@ Material:
m_Colors:
- _Color: {r: 0.51, g: 0.51, b: 0.89, a: 1}
- _EmissionColor: {r: 0, g: 0, b: 0, a: 1}
m_BuildTextureStacks: []
Loading
Loading