Use absolute paths to reference models in unit tests #168

xela-95 · 2024-05-06T10:49:18Z

Fixes #164

xela-95 · 2024-05-06T12:12:04Z

Apparently the modification of unit test paths to models used by the fixture (that was needed BTW) is not sufficient to make the CI pass.

xela-95 · 2024-05-06T12:16:58Z

The error log that can be the symptom of something not working properly is Error in gzyarp::DeviceRegistry::getDevicesKeys: gz instance not found, printed in

gz-sim-yarp-plugins/libraries/device-registry/DeviceRegistry.cc

Lines 50 to 56 in bdb1cd9

    
           if (auto gzInstance_it = m_devicesMap.find(gzInstanceId); 
        
               gzInstance_it == m_devicesMap.end()) 
        
           { 
        
               yError() << "Error in gzyarp::DeviceRegistry::getDevicesAsPolyDriverList: gz instance " 
        
                           "not found"; 
        
               return false; 
        
           }

This could be an indication that the pointer of the ECM used as the indicator of the Gazebo instance in use could pose issues. What do you think @traversaro?

xela-95 · 2024-05-06T12:23:25Z

From the ForceTorqueTest the error:

[INFO] |yarp.os.Port|/ForceTorqueTest/rpc:i| Port /ForceTorqueTest/rpc:i active at tcp://127.0.0.1:10002/
[INFO] |yarp.os.Port|/ForceTorqueTest/measures:i| Port /ForceTorqueTest/measures:i active at tcp://127.0.0.1:10003/
Error:  |yarp.device.multipleanalogsensorsclient| Failure connecting port /ForceTorqueTest/rpc:i to /forcetorque/rpc:o.
Error:  |yarp.device.multipleanalogsensorsclient| Check that the specified MultipleAnalogSensorsServer is up.
[DEBUG] |yarp.device.multipleanalogsensorsclient| Close complete
Error:  |yarp.dev.PolyDriver|multipleanalogsensorsclient| Driver <multipleanalogsensorsclient> was found but could not open

and from the ClockTest:

Error:  |yarp.os.Port| YARP not initialized; create a yarp::os::Network object before using ports

are making me think of something with YARP, but it's strange that these error started occurring the past week, also because the Yarp version has not changed AFAIK.

traversaro · 2024-05-13T08:39:40Z

When trying to create on my local machine the environment used on the Conda CI for Ubuntu 22.04 exported with conda list --explicit I get the following error:
CondaValueError: could not parse 'https://conda.anaconda.org/conda-forge/linux-64/x264-1!164.3095-h166bdaf_2.tar.bz2' in: /home/acroci/Desktop/debug_conda_ci/conda_ci_env.txt
Here's the output of the conda list --explicit:
Details

I'm trying to create the environment with the following command: mamba create --name conda_ci --file <filepath.txt>

Any clue about this @traversaro?

Not sure, how did you solved?

xela-95 · 2024-05-13T08:45:40Z

When trying to create on my local machine the environment used on the Conda CI for Ubuntu 22.04 exported with conda list --explicit I get the following error:
CondaValueError: could not parse 'https://conda.anaconda.org/conda-forge/linux-64/x264-1!164.3095-h166bdaf_2.tar.bz2' in: /home/acroci/Desktop/debug_conda_ci/conda_ci_env.txt
Here's the output of the conda list --explicit:
Details
I'm trying to create the environment with the following command: mamba create --name conda_ci --file <filepath.txt>
Any clue about this @traversaro?
Not sure, how did you solved?

I've did two things so not sure which one is the real solution.

First I updated my mamba version, then I copied to the txt file the entire output of conda list --explicit, including the headers:

# This file may be used to create an environment using:
# $ conda create --name <env> --file <this file>
# platform: linux-64
@EXPLICIT

xela-95 · 2024-05-13T08:46:06Z

In this way I'm finally able to reproduce locally the failures of the tests.

xela-95 · 2024-05-13T09:28:41Z

The error message [Err] [Server.cc:198] Error Code 40: Msg: Error parsing XML in file [/home/runner/micromamba/envs/gzyarppluginsdev/share/ comes from sdformat package: https://github.com/gazebosim/sdformat/blob/6f1c36502f1085836ab9876e26afac3238f26820/src/parser.cc#L844-L850

traversaro · 2024-05-13T09:33:45Z

The diff between sdformat 14.0.0 and 14.2.0 is gazebosim/sdformat@sdformat14_14.0.0...sdformat14_14.2.0 .

traversaro · 2024-05-13T09:36:16Z

The diff between sdformat 14.0.0 and 14.2.0 is gazebosim/sdformat@sdformat14_14.0.0...sdformat14_14.2.0 .

This change may be related: gazebosim/sdformat#1239 .

traversaro · 2024-05-13T09:38:50Z

The diff between sdformat 14.0.0 and 14.2.0 is gazebosim/sdformat@sdformat14_14.0.0...sdformat14_14.2.0 .

This change may be related: gazebosim/sdformat#1239 .

In particular this function: https://github.com/gazebosim/sdformat/pull/1239/files#diff-497b59a757dc6d26ca6ec70d1e804f60c934bd2c0f53ffbe8551a010dee6844dR46 .

traversaro · 2024-05-13T09:41:36Z

The diff between sdformat 14.0.0 and 14.2.0 is gazebosim/sdformat@sdformat14_14.0.0...sdformat14_14.2.0 .

This change may be related: gazebosim/sdformat#1239 .

In particular this function: https://github.com/gazebosim/sdformat/pull/1239/files#diff-497b59a757dc6d26ca6ec70d1e804f60c934bd2c0f53ffbe8551a010dee6844dR46 .

And all may boil down to gazebosim/sdformat#198 . I am not sure why conda's binary prefix relocation is not working anymore (see https://docs.conda.io/projects/conda-build/en/latest/resources/make-relocatable.html), but that is indeed a tricky machinery (that anyhow does not work on Windows), and that the reason why we switched to explicitly making the packages relocatable in gazebosim/gz-sim#626 .

xela-95 · 2024-05-13T09:58:42Z

And all may boil down to gazebosim/sdformat#198 . I am not sure why conda's binary prefix relocation is not working anymore (see https://docs.conda.io/projects/conda-build/en/latest/resources/make-relocatable.html), but that is indeed a tricky machinery (that anyhow does not work on Windows), and that the reason why we switched to explicitly making the packages relocatable in gazebosim/gz-sim#626 .

Ok thank you so much for unravelling this tangle! So to recap the issue could be due to the fact that when passing the path of the SDF model to the TestFixture class of gz-sim, it searches for it only in its installation directory?

xela-95 · 2024-05-13T10:00:41Z

@traversaro how do you suggest to proceed?

traversaro · 2024-05-13T10:00:41Z

Ok thank you so much for unravelling this tangle! So to recap the issue could be due to the fact that when passing the path of the SDF model to the TestFixture class of gz-sim, it searches for it only in its installation directory?

Not really. My hypothesis is that he is not able to find anymore some SDF files, that however are not related to the .world file that we pass. Can you check if gz sim shapes.sdf is able to start correctly from the command line?

traversaro · 2024-05-13T10:03:34Z

@traversaro how do you suggest to proceed?

Can you try to check a standalone TestFixture example from gz-sim (for example https://gazebosim.org/api/sim/8/test_fixture.html) and see if it reproduces the problem? If yes, I would open an issue in https://github.com/conda-forge/libsdformat-feedstock and pin sdformat to 14.0.0 in the CI in the meanwhile.

xela-95 · 2024-05-13T10:11:44Z

Not really. My hypothesis is that he is not able to find anymore some SDF files, that however are not related to the .world file that we pass. Can you check if gz sim shapes.sdf is able to start correctly from the command

when running it I get the same error:

[Err] [Server.cc:198] Error Code 40: Msg: Error parsing XML in file [/home/acroci/mambaforge/envs/conda_ci/share/
[Err] [Server.cc:198] Error Code 1: Msg: File [] doesn't exist.
[Err] [Server.cc:198] Error Code 1: Msg: Unable to read file: [/home/acroci/mambaforge/envs/conda_ci/share/gz/gz-sim8/worlds/shapes.sdf]

xela-95 · 2024-05-13T10:27:37Z

Can you try to check a standalone TestFixture example from gz-sim (for example https://gazebosim.org/api/sim/8/test_fixture.html) and see if it reproduces the problem? If yes, I would open an issue in https://github.com/conda-forge/libsdformat-feedstock and pin sdformat to 14.0.0 in the CI in the meanwhile.

I compiled and ran the standalone tests in https://github.com/gazebosim/gz-sim/tree/gz-sim8_8.3.0/examples/standalone/gtest_setup

They report the same errors we are experiencing.

gravity_TEST:

./gravity_TEST
Running main() from /home/acroci/repos/gz-sim/examples/standalone/gtest_setup/build/_deps/googletest-src/googletest/src/gtest_main.cc
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from ExampleTests
[ RUN      ] ExampleTests.Gravity
[Msg] Loading SDF world file[/home/acroci/repos/gz-sim/examples/standalone/gtest_setup/gravity.sdf].
[Err] [Server.cc:198] Error Code 40: Msg: Error parsing XML in file [/home/acroci/mambaforge/envs/conda_ci/share/
[Err] [Server.cc:198] Error Code 1: Msg: File [] doesn't exist.
[Err] [Server.cc:198] Error Code 1: Msg: Unable to read file: [/home/acroci/repos/gz-sim/examples/standalone/gtest_setup/gravity.sdf]
/home/acroci/repos/gz-sim/examples/standalone/gtest_setup/gravity_TEST.cc:85: Failure
Expected equality of these values:
  1000
  iterations
    Which is: 0
[  FAILED  ] ExampleTests.Gravity (50 ms)
[----------] 1 test from ExampleTests (50 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (50 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ExampleTests.Gravity

 1 FAILED TEST

command_TEST

./command_TEST
Running main() from /home/acroci/repos/gz-sim/examples/standalone/gtest_setup/build/_deps/googletest-src/googletest/src/gtest_main.cc
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from ExampleTests
[ RUN      ] ExampleTests.Command
[Msg] Loading SDF world file[/home/acroci/repos/gz-sim/examples/standalone/gtest_setup/command.sdf].
[Err] [Server.cc:198] Error Code 40: Msg: Error parsing XML in file [/home/acroci/mambaforge/envs/conda_ci/share/
[Err] [Server.cc:198] Error Code 1: Msg: File [] doesn't exist.
[Err] [Server.cc:198] Error Code 1: Msg: Unable to read file: [/home/acroci/repos/gz-sim/examples/standalone/gtest_setup/command.sdf]
/home/acroci/repos/gz-sim/examples/standalone/gtest_setup/command_TEST.cc:74: Failure
Value of: configured
  Actual: false
Expected: true
/home/acroci/repos/gz-sim/examples/standalone/gtest_setup/command_TEST.cc:97: Failure
Expected equality of these values:
  expectedIterations
    Which is: 10
  iterations
    Which is: 0
/home/acroci/repos/gz-sim/examples/standalone/gtest_setup/command_TEST.cc:99: Failure
Expected: (0.0) > (linVel.Z()), actual: 0 vs 0
/home/acroci/repos/gz-sim/examples/standalone/gtest_setup/command_TEST.cc:100: Failure
Expected: (0.0) > (linAccel.Z()), actual: 0 vs 0
/home/acroci/repos/gz-sim/examples/standalone/gtest_setup/command_TEST.cc:123: Failure
Expected: (sleep) < (maxSleep), actual: 30 vs 30
/home/acroci/repos/gz-sim/examples/standalone/gtest_setup/command_TEST.cc:124: Failure
Expected equality of these values:
  expectedIterations
    Which is: 310
  iterations
    Which is: 0
/home/acroci/repos/gz-sim/examples/standalone/gtest_setup/command_TEST.cc:126: Failure
Expected equality of these values:
  10.0
    Which is: 10
  linVel.X()
    Which is: 0
/home/acroci/repos/gz-sim/examples/standalone/gtest_setup/command_TEST.cc:127: Failure
Expected: (0.0) > (linVel.Z()), actual: 0 vs 0
/home/acroci/repos/gz-sim/examples/standalone/gtest_setup/command_TEST.cc:128: Failure
Expected: (0.0) > (linAccel.Z()), actual: 0 vs 0
[  FAILED  ] ExampleTests.Command (3056 ms)
[----------] 1 test from ExampleTests (3056 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (3056 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ExampleTests.Command

 1 FAILED TEST

traversaro · 2024-05-13T10:30:00Z

They report the same errors we are experiencing.

Great, can you open an issue at https://github.com/conda-forge/libsdformat-feedstock ? Thanks!

xela-95 · 2024-05-13T10:47:25Z

Great, can you open an issue at https://github.com/conda-forge/libsdformat-feedstock ? Thanks!

Opened conda-forge/libsdformat-feedstock#116

traversaro · 2024-05-13T11:16:33Z

Given conda-forge/admin-requests#994 (comment), you can probably remove the pinning of sdformat .

xela-95 · 2024-05-13T13:59:40Z

Finally the Conda CI is passing for all platforms.

traversaro · 2024-05-13T15:15:10Z

It seems that the apt CI is failing?

xela-95 · 2024-05-13T15:25:41Z

It seems that the apt CI is failing?

Yep, that's addressed by #166, I would merge it after this one.

traversaro · 2024-05-13T15:28:26Z

It seems that the apt CI is failing?

Yep, that's addressed by #166, I would merge it after this one.

Ok!

traversaro · 2024-05-13T15:29:48Z

It seems that the apt CI is failing?

Yep, that's addressed by #166, I would merge it after this one.

Are you sure that disabling codecov will be sufficient? This CI on apt fails with error:

[38/53] Building CXX object tests/controlboard/CMakeFiles/ControlBoardTorqueControlTest.dir/ControlBoardTorqueControlTest.cc.o
FAILED: tests/controlboard/CMakeFiles/ControlBoardTorqueControlTest.dir/ControlBoardTorqueControlTest.cc.o 
/usr/bin/c++ -DCMAKE_CURRENT_SOURCE_DIR=\"/home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/tests/controlboard\" -DHAVE_PYBIND11 -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_QMLMODELS_LIB -DQT_QML_LIB -DQT_QUICKCONTROLS2_LIB -DQT_QUICK_LIB -DQT_WIDGETS_LIB -I/home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/tests/test-helpers -I/home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/libraries/device-registry -I/home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/libraries/common -I/home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/plugins/controlboard/include -isystem /usr/include/gz/sim8 -isystem /usr/include/gz/math7 -isystem /usr/include/gz/utils2 -isystem /usr/include/gz/plugin2 -isystem /usr/include/gz/common5 -isystem /usr/include/uuid -isystem /usr/include/gz/fuel_tools9 -isystem /usr/include/gz/msgs10 -isystem /usr/include/gz/gui8 -isystem /usr/include/gz/transport13 -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtQml -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtQuick -isystem /usr/include/x86_64-linux-gnu/qt5/QtQmlModels -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtQuickControls2 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/gz/physics7 -isystem /usr/include/eigen3 -isystem /usr/include/gz/rendering8 -isystem /usr/include/gz/sdformat14 -isystem /home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/install/deps/include --coverage -g -O0 -DGTEST_HAS_PTHREAD=1 -I/usr/include/uuid -I/usr/include -fPIC -I/usr/include/x86_64-linux-gnu -MD -MT tests/controlboard/CMakeFiles/ControlBoardTorqueControlTest.dir/ControlBoardTorqueControlTest.cc.o -MF tests/controlboard/CMakeFiles/ControlBoardTorqueControlTest.dir/ControlBoardTorqueControlTest.cc.o.d -o tests/controlboard/CMakeFiles/ControlBoardTorqueControlTest.dir/ControlBoardTorqueControlTest.cc.o -c /home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/tests/controlboard/ControlBoardTorqueControlTest.cc
/home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/tests/controlboard/ControlBoardTorqueControlTest.cc: In constructor ‘gzyarp::test::ControlBoardTorqueControlFixture::ControlBoardTorqueControlFixture()’:
/home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/tests/controlboard/ControlBoardTorqueControlTest.cc:43:41: error: ‘path’ is not a member of ‘std::filesystem’
   43 |         : testFixture{(std::filesystem::path(CMAKE_CURRENT_SOURCE_DIR) / GetParam()).string()}
      |                                         ^~~~
/home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/tests/controlboard/ControlBoardTorqueControlTest.cc:43:11: error: no matching function for call to ‘gz::sim::v8::TestFixture::TestFixture(<brace-enclosed initializer list>)’
   43 |         : testFixture{(std::filesystem::path(CMAKE_CURRENT_SOURCE_DIR) / GetParam()).string()}
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/tests/controlboard/ControlBoardTorqueControlTest.cc:19:
/usr/include/gz/sim8/gz/sim/TestFixture.hh:66:20: note: candidate: ‘gz::sim::v8::TestFixture::TestFixture(const gz::sim::v8::ServerConfig&)’
   66 |   public: explicit TestFixture(const ServerConfig &_config);
      |                    ^~~~~~~~~~~
/usr/include/gz/sim8/gz/sim/TestFixture.hh:66:20: note:   conversion of argument 1 would be ill-formed:
/usr/include/gz/sim8/gz/sim/TestFixture.hh:62:20: note: candidate: ‘gz::sim::v8::TestFixture::TestFixture(const string&)’
   62 |   public: explicit TestFixture(const std::string &_path);
      |                    ^~~~~~~~~~~
/usr/include/gz/sim8/gz/sim/TestFixture.hh:62:20: note:   conversion of argument 1 would be ill-formed:
[39/53] Building CXX object tests/controlboard/CMakeFiles/ControlBoardPositionDirectControlTest.dir/ControlBoardPositionDirectControlTest.cc.o
[40/53] Building CXX object tests/controlboard/CMakeFiles/ControlBoardPositionControlTest.dir/ControlBoardPositionControlTest.cc.o
[41/53] Building CXX object tests/commons/CMakeFiles/ConfigurationParsingFromFileTest.dir/ConfigurationParsingFromFileTest.cc.o
[42/53] Building CXX object tests/controlboard/CMakeFiles/ControlBoardOnMultipleGazeboInstancesTest.dir/ControlBoardOnMultipleGazeboInstancesTest.cc.o
[43/53] Building CXX object tests/controlboard/CMakeFiles/ControlBoardCommonsTest.dir/ControlBoardCommonsTest.cc.o
ninja: build stopped: subcommand failed.
Error: Process completed with exit code 1.

that is different from the error mentioned in that issue.

xela-95 · 2024-05-13T15:33:52Z

Are you sure that disabling codecov will be sufficient? This CI on apt fails with error:

[38/53] Building CXX object tests/controlboard/CMakeFiles/ControlBoardTorqueControlTest.dir/ControlBoardTorqueControlTest.cc.o
FAILED: tests/controlboard/CMakeFiles/ControlBoardTorqueControlTest.dir/ControlBoardTorqueControlTest.cc.o 
/usr/bin/c++ -DCMAKE_CURRENT_SOURCE_DIR=\"/home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/tests/controlboard\" -DHAVE_PYBIND11 -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_QMLMODELS_LIB -DQT_QML_LIB -DQT_QUICKCONTROLS2_LIB -DQT_QUICK_LIB -DQT_WIDGETS_LIB -I/home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/tests/test-helpers -I/home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/libraries/device-registry -I/home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/libraries/common -I/home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/plugins/controlboard/include -isystem /usr/include/gz/sim8 -isystem /usr/include/gz/math7 -isystem /usr/include/gz/utils2 -isystem /usr/include/gz/plugin2 -isystem /usr/include/gz/common5 -isystem /usr/include/uuid -isystem /usr/include/gz/fuel_tools9 -isystem /usr/include/gz/msgs10 -isystem /usr/include/gz/gui8 -isystem /usr/include/gz/transport13 -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtQml -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtQuick -isystem /usr/include/x86_64-linux-gnu/qt5/QtQmlModels -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtQuickControls2 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/gz/physics7 -isystem /usr/include/eigen3 -isystem /usr/include/gz/rendering8 -isystem /usr/include/gz/sdformat14 -isystem /home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/install/deps/include --coverage -g -O0 -DGTEST_HAS_PTHREAD=1 -I/usr/include/uuid -I/usr/include -fPIC -I/usr/include/x86_64-linux-gnu -MD -MT tests/controlboard/CMakeFiles/ControlBoardTorqueControlTest.dir/ControlBoardTorqueControlTest.cc.o -MF tests/controlboard/CMakeFiles/ControlBoardTorqueControlTest.dir/ControlBoardTorqueControlTest.cc.o.d -o tests/controlboard/CMakeFiles/ControlBoardTorqueControlTest.dir/ControlBoardTorqueControlTest.cc.o -c /home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/tests/controlboard/ControlBoardTorqueControlTest.cc
/home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/tests/controlboard/ControlBoardTorqueControlTest.cc: In constructor ‘gzyarp::test::ControlBoardTorqueControlFixture::ControlBoardTorqueControlFixture()’:
/home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/tests/controlboard/ControlBoardTorqueControlTest.cc:43:41: error: ‘path’ is not a member of ‘std::filesystem’
   43 |         : testFixture{(std::filesystem::path(CMAKE_CURRENT_SOURCE_DIR) / GetParam()).string()}
      |                                         ^~~~
/home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/tests/controlboard/ControlBoardTorqueControlTest.cc:43:11: error: no matching function for call to ‘gz::sim::v8::TestFixture::TestFixture(<brace-enclosed initializer list>)’
   43 |         : testFixture{(std::filesystem::path(CMAKE_CURRENT_SOURCE_DIR) / GetParam()).string()}
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/runner/work/gz-sim-yarp-plugins/gz-sim-yarp-plugins/tests/controlboard/ControlBoardTorqueControlTest.cc:19:
/usr/include/gz/sim8/gz/sim/TestFixture.hh:66:20: note: candidate: ‘gz::sim::v8::TestFixture::TestFixture(const gz::sim::v8::ServerConfig&)’
   66 |   public: explicit TestFixture(const ServerConfig &_config);
      |                    ^~~~~~~~~~~
/usr/include/gz/sim8/gz/sim/TestFixture.hh:66:20: note:   conversion of argument 1 would be ill-formed:
/usr/include/gz/sim8/gz/sim/TestFixture.hh:62:20: note: candidate: ‘gz::sim::v8::TestFixture::TestFixture(const string&)’
   62 |   public: explicit TestFixture(const std::string &_path);
      |                    ^~~~~~~~~~~
/usr/include/gz/sim8/gz/sim/TestFixture.hh:62:20: note:   conversion of argument 1 would be ill-formed:
[39/53] Building CXX object tests/controlboard/CMakeFiles/ControlBoardPositionDirectControlTest.dir/ControlBoardPositionDirectControlTest.cc.o
[40/53] Building CXX object tests/controlboard/CMakeFiles/ControlBoardPositionControlTest.dir/ControlBoardPositionControlTest.cc.o
[41/53] Building CXX object tests/commons/CMakeFiles/ConfigurationParsingFromFileTest.dir/ConfigurationParsingFromFileTest.cc.o
[42/53] Building CXX object tests/controlboard/CMakeFiles/ControlBoardOnMultipleGazeboInstancesTest.dir/ControlBoardOnMultipleGazeboInstancesTest.cc.o
[43/53] Building CXX object tests/controlboard/CMakeFiles/ControlBoardCommonsTest.dir/ControlBoardCommonsTest.cc.o
ninja: build stopped: subcommand failed.
Error: Process completed with exit code 1.

that is different from the error mentioned in that issue.

Oh sorry I didn't see it!

…vironement

xela-95 · 2024-05-13T15:55:50Z

Now the CI is passing. Merging

xela-95 self-assigned this May 6, 2024

xela-95 force-pushed the fix/conda-ci-failure branch from 028e055 to bdb1cd9 Compare May 6, 2024 12:10

This comment was marked as resolved.

Sign in to view

xela-95 force-pushed the fix/conda-ci-failure branch 2 times, most recently from 2fff1f0 to 22bd0e5 Compare May 13, 2024 12:51

xela-95 marked this pull request as ready for review May 13, 2024 13:59

xela-95 requested a review from traversaro May 13, 2024 13:59

traversaro approved these changes May 13, 2024

View reviewed changes

xela-95 force-pushed the fix/conda-ci-failure branch from 22bd0e5 to c93dcf3 Compare May 13, 2024 15:32

xela-95 added 2 commits May 13, 2024 17:43

Use absolute paths to reference models in unit tests

76c9e82

Add --explicit argument to conda list to be able to clone used en…

076727a

…vironement

xela-95 force-pushed the fix/conda-ci-failure branch from c93dcf3 to 076727a Compare May 13, 2024 15:43

xela-95 merged commit b3577c7 into main May 13, 2024
7 checks passed

xela-95 deleted the fix/conda-ci-failure branch May 13, 2024 15:56

traversaro mentioned this pull request Aug 2, 2024

crash when loading ergoCubGazeboV1_1 in gz sim #173

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use absolute paths to reference models in unit tests #168

Use absolute paths to reference models in unit tests #168

xela-95 commented May 6, 2024

xela-95 commented May 6, 2024

xela-95 commented May 6, 2024

xela-95 commented May 6, 2024

This comment was marked as resolved.

traversaro commented May 13, 2024

xela-95 commented May 13, 2024 •

edited

Loading

xela-95 commented May 13, 2024

xela-95 commented May 13, 2024

traversaro commented May 13, 2024

traversaro commented May 13, 2024

traversaro commented May 13, 2024

traversaro commented May 13, 2024

xela-95 commented May 13, 2024

xela-95 commented May 13, 2024

traversaro commented May 13, 2024

traversaro commented May 13, 2024

xela-95 commented May 13, 2024

xela-95 commented May 13, 2024

traversaro commented May 13, 2024

xela-95 commented May 13, 2024

traversaro commented May 13, 2024

xela-95 commented May 13, 2024

traversaro commented May 13, 2024

xela-95 commented May 13, 2024

traversaro commented May 13, 2024

traversaro commented May 13, 2024

xela-95 commented May 13, 2024

xela-95 commented May 13, 2024

Use absolute paths to reference models in unit tests #168

Use absolute paths to reference models in unit tests #168

Conversation

xela-95 commented May 6, 2024

xela-95 commented May 6, 2024

xela-95 commented May 6, 2024

xela-95 commented May 6, 2024

This comment was marked as resolved.

traversaro commented May 13, 2024

xela-95 commented May 13, 2024 • edited Loading

xela-95 commented May 13, 2024

xela-95 commented May 13, 2024

traversaro commented May 13, 2024

traversaro commented May 13, 2024

traversaro commented May 13, 2024

traversaro commented May 13, 2024

xela-95 commented May 13, 2024

xela-95 commented May 13, 2024

traversaro commented May 13, 2024

traversaro commented May 13, 2024

xela-95 commented May 13, 2024

xela-95 commented May 13, 2024

gravity_TEST:

command_TEST

traversaro commented May 13, 2024

xela-95 commented May 13, 2024

traversaro commented May 13, 2024

xela-95 commented May 13, 2024

traversaro commented May 13, 2024

xela-95 commented May 13, 2024

traversaro commented May 13, 2024

traversaro commented May 13, 2024

xela-95 commented May 13, 2024

xela-95 commented May 13, 2024

xela-95 commented May 13, 2024 •

edited

Loading