DynamixelAX12 device fix

Bindings fix Fixed destructor of DeviceDriver class
robotology · Dec 11, 2023 · bc2d424 · bc2d424
1 parent 60a779c
commit bc2d424
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/bindings/yarp.i b/bindings/yarp.i
@@ -392,7 +392,6 @@ MAKE_COMMS(Bottle)
 %include <yarp/sig/Sound.h>
 %include <yarp/sig/Matrix.h>
 %include <yarp/sig/Vector.h>
-%include <yarp/os/IOpenClose.h>
 %include <yarp/dev/DeviceDriver.h>
 %include <yarp/dev/PolyDriver.h>
 %include <yarp/dev/Drivers.h>

diff --git a/src/devices/DynamixelAX12Ftdi/DynamixelAX12FtdiDriver.h b/src/devices/DynamixelAX12Ftdi/DynamixelAX12FtdiDriver.h
@@ -189,7 +189,7 @@ class DynamixelAX12FtdiDriver :
         @param config Config file containing string pairs for parameters
         @return true on success
      */
-    bool configure(yarp::os::Searchable& config) override;
+    bool configure(yarp::os::Searchable& config);
 
     /** Send instruction to device
         Send an instruction to a device of given ID. The instruction has to be a byte arry containing

diff --git a/src/libYARP_dev/src/yarp/dev/DeviceDriver.h b/src/libYARP_dev/src/yarp/dev/DeviceDriver.h
@@ -34,7 +34,7 @@ class YARP_dev_API yarp::dev::DeviceDriver
     DeviceDriver& operator=(const DeviceDriver& other) = delete;
     DeviceDriver& operator=(DeviceDriver&& other) noexcept = delete;
 
-    ~DeviceDriver();
+    virtual ~DeviceDriver();
 
     /**
      * Open the DeviceDriver.

diff --git a/src/libYARP_dev/src/yarp/dev/Drivers.cpp b/src/libYARP_dev/src/yarp/dev/Drivers.cpp
@@ -189,7 +189,7 @@ class StubDriver : public DeviceDriver {
         init();
     }
 
-    ~StubDriver() = default;
+    virtual ~StubDriver() = default;
 
     void init() {
         if (plugin.open(settings)) {