Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General improvements to all devices tests #3024

Merged
merged 21 commits into from
Nov 8, 2023
Merged

General improvements to all devices tests #3024

merged 21 commits into from
Nov 8, 2023

Conversation

randaz81
Copy link
Member

No description provided.

@randaz81 randaz81 self-assigned this Sep 19, 2023
@randaz81 randaz81 requested a review from Nicogene as a code owner September 19, 2023 08:52
@update-docs
Copy link

update-docs bot commented Sep 19, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

@randaz81 randaz81 added this to the YARP 3.9.0 milestone Sep 19, 2023
traversaro
traversaro previously approved these changes Sep 19, 2023
View reviewed changes
Nicogene
Nicogene previously approved these changes Sep 19, 2023
View reviewed changes
@randaz81 randaz81 temporarily deployed to code-analysis September 19, 2023 09:20 — with GitHub Actions Inactive
@randaz81 randaz81 temporarily deployed to code-analysis September 19, 2023 09:21 — with GitHub Actions Inactive
@randaz81 randaz81 temporarily deployed to code-analysis September 19, 2023 09:21 — with GitHub Actions Inactive
@randaz81 randaz81 dismissed stale reviews from Nicogene and traversaro via a92fa52 September 19, 2023 13:46
@randaz81 randaz81 force-pushed the tests_check_improved branch from 8d82bfc to a92fa52 Compare September 19, 2023 13:46
@randaz81 randaz81 temporarily deployed to code-analysis September 19, 2023 13:51 — with GitHub Actions Inactive
@randaz81 randaz81 temporarily deployed to code-analysis September 19, 2023 15:55 — with GitHub Actions Inactive
@randaz81 randaz81 temporarily deployed to code-analysis September 19, 2023 15:55 — with GitHub Actions Inactive
@randaz81 randaz81 temporarily deployed to code-analysis September 19, 2023 15:55 — with GitHub Actions Inactive
@randaz81 randaz81 temporarily deployed to code-analysis September 19, 2023 19:12 — with GitHub Actions Inactive
@randaz81 randaz81 temporarily deployed to code-analysis September 19, 2023 19:12 — with GitHub Actions Inactive
@randaz81 randaz81 temporarily deployed to code-analysis September 19, 2023 19:12 — with GitHub Actions Inactive
@randaz81 randaz81 force-pushed the tests_check_improved branch from 959afee to b2d9541 Compare September 19, 2023 20:43
@randaz81 randaz81 temporarily deployed to code-analysis September 19, 2023 20:45 — with GitHub Actions Inactive
@randaz81 randaz81 temporarily deployed to code-analysis September 19, 2023 20:45 — with GitHub Actions Inactive
@randaz81 randaz81 temporarily deployed to code-analysis September 19, 2023 22:45 — with GitHub Actions Inactive
@randaz81 randaz81 temporarily deployed to code-analysis September 19, 2023 22:45 — with GitHub Actions Inactive
randaz81 added 10 commits November 7, 2023 17:09
@randaz81
added harness_test1, harness_test2, harness_test3
b63a91a
@randaz81
improved fakeNavigation_test.cpp
9394a1d
@randaz81
added CarriersTest.cpp
2db9a1f
@randaz81
added ListPluginsTest.cpp
235bab1
@randaz81
fix
0c204b5
@randaz81
Improved LogTest and LogStreamTest. Fixed issue preventing correct op…
7fed48c 
…eration with empty log strings.
@randaz81
Improvements to controlBoard_nws_yarp (mandatory interfaces)
efd7139 
Added test `IEncodersTimedTest`.
Added encoders test to fakeMotionControl_test, remoteControlBoard_test.
@randaz81
fixed coverage/issues in tests code spotted by sonarcloud
410e570
@randaz81
added IVelocityControlTest
2cb915c 
improvements to IPositionControlTest, ITorqueControlTest, IEncodersTimedTest
added new test device FakeMotionControlMicro + test
improvements to RemoteControlBoard_test, controlBoard_nws_yarp tests
RemoteControlBoard_test, controlBoard_nws_yarp modified in order to have positionControl interface not mandatory
@randaz81
improved CI tests
8029300
@randaz81 randaz81 force-pushed the tests_check_improved branch from 52c978e to 8029300 Compare November 7, 2023 16:10
@randaz81
Removed from ci.yml some definitions which were excluding specific de…
8a0bcc4 
…vices/plugins to be compiled and subsequently tested with valgrind.

The next commit will disable these plugins directly in their own folder, using a specific new definition related to valgrind testing.
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 151 Code Smells

45.4% 45.4% Coverage
13.7% 13.7% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@randaz81
Added YARP_DISABLE_FAILING_VALGRIND_TESTS option which maps to DISABL…
38f2265 
…E_FAILING_VALGRIND_TESTS compiler definition
@randaz81 randaz81 merged commit 2e201b6 into robotology:master Nov 8, 2023
16 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicogene Nicogene Nicogene left review comments

@traversaro traversaro traversaro left review comments

Assignees

@randaz81 randaz81

Labels
Component: Tests
Projects
None yet
Milestone
YARP 3.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@randaz81 @traversaro @Nicogene