Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Use OpenCV_LIBS instead of OpenCV_LIBRARIES as documented in official OpenCV docs #3055

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

traversaro
Copy link
Member

OpenCV_LIBS is the variable documented in official OpenCV docs (https://docs.opencv.org/4.x/db/df5/tutorial_linux_gcc_cmake.html). OpenCV_LIBRARIES was a YCM extension, that is going to be deprecated (see robotology/ycm-cmake-modules#434).

@traversaro traversaro requested a review from randaz81 November 27, 2023 16:02
@traversaro
Copy link
Member Author

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

This is an internal change that does not change anything for the external users, so I think it make sense not to document it to avoid increasing the noise in release notes.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@randaz81 randaz81 merged commit eb4243a into robotology:master Nov 29, 2023
48 of 52 checks passed
@randaz81 randaz81 added this to the YARP 3.10.0 milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants