Fix testTypeParameterConstructors04 and others

Signed-off-by: Rob Stryker <stryker@redhat.com>
robstryker · Nov 25, 2024 · 1ad70d1 · 1ad70d1
1 parent ec651f9
commit 1ad70d1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/javac/dom/JavacTypeBinding.java b/org.eclipse.jdt.core.javac/src/org/eclipse/jdt/internal/javac/dom/JavacTypeBinding.java
@@ -773,9 +773,13 @@ public String getName(boolean checkParameterized) {
 			ITypeBinding[] types = this.getUncheckedTypeArguments(this.type, this.typeSymbol);
 			if (types != null && types.length > 0) {
 				builder.append("<");
-				for (var typeArgument : types) {
-					if (typeArgument != null) {
-						builder.append(typeArgument.getName());
+				for (int z = 0; z < types.length; z++ ) {
+					ITypeBinding zBinding = types[z];
+					if (zBinding != null) {
+						builder.append(zBinding.getName());
+						if( z != types.length - 1) {
+							builder.append(",");
+						}
 					}
 				}
 				builder.append(">");

diff --git a/...e.jdt.core/search/org/eclipse/jdt/internal/core/search/matching/TypeParameterLocator.java b/...e.jdt.core/search/org/eclipse/jdt/internal/core/search/matching/TypeParameterLocator.java
@@ -155,8 +155,9 @@ protected int matchTypeParameter(ITypeBinding variable, boolean matchName) {
 				if (methBinding.getParameterTypes() == null) {
 					if (length == 0) return ACCURATE_MATCH;
 				} else if (methBinding.getParameterTypes().length == length){
+					ITypeBinding[] p = methBinding.getParameterTypes();
 					for (int i=0; i<length; i++) {
-						if (!matchesName(methBinding.getParameterTypes()[i].getName().toCharArray(), this.pattern.methodArgumentTypes[i])) {
+						if (!matchesName(this.pattern.methodArgumentTypes[i], p[i].getName().toCharArray())) {
 							return IMPOSSIBLE_MATCH;
 						}
 					}