Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rockcarver/frodo-lib#391 and upgrade to frodo-lib 2.0.0-74 #380

Merged
merged 1 commit into from
Mar 23, 2024
Merged

fix rockcarver/frodo-lib#391 and upgrade to frodo-lib 2.0.0-74 #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,36 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Update to frodo-lib 2.0.0-74

### Fixed

- rockcarver/frodo-lib#391: Frodo now creates service accounts with all allowed scopes:
- `fr:am:*`
- `fr:idc:analytics:*`
- `fr:autoaccess:*`
- `fr:idc:certificate:*`
- `fr:idc:certificate:read`
- `fr:idc:content-security-policy:*`
- `fr:idc:custom-domain:*`
- `fr:idc:esv:*`
- `fr:idc:esv:read`
- `fr:idc:esv:restart`
- `fr:idc:esv:update`
- `fr:idm:*`
- `fr:iga:*`
- `fr:idc:promotion:*`
- `fr:idc:release:*`
- `fr:idc:sso-cookie:*`

## [2.0.0-52] - 2024-03-23

### Changed

- Update to frodo-lib 2.0.0-73

### Fixed

- \#378: `--llt` option of `frodo admin create-oauth2-client-with-admin-privileges` now works properly again
Expand Down
12 changes: 6 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
]
},
"dependencies": {
"@rockcarver/frodo-lib": "2.0.0-73",
"@rockcarver/frodo-lib": "2.0.0-74",
"chokidar": "^3.5.3",
"cli-progress": "^3.11.2",
"cli-table3": "^0.6.3",
Expand Down
2 changes: 2 additions & 0 deletions src/ops/ConnectionProfileOps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ export async function describeConnectionProfile(
delete profile.svcacctId;
delete profile.svcacctJwk;
delete profile.svcacctName;
delete profile.svcacctScope;
}
if (showSecrets && jwk) {
(profile as unknown)['svcacctJwk'] = 'see below';
Expand All @@ -112,6 +113,7 @@ export async function describeConnectionProfile(
svcacctName: 'Service Account Name',
svcacctId: 'Service Account Id',
svcacctJwk: 'Service Account JWK',
svcacctScope: 'Service Account Scope',
};
const table = createObjectTable(profile, keyMap);
printMessage(table.toString(), 'data');
Expand Down
Loading