Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and Improve Imports and Exports #448

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

phalestrivir
Copy link
Contributor

This PR makes some fixes and improvements to Frodo imports and exports. This PR is part of a bigger PR that adds additional imports/exports into Frodo, but due to the amount of bug fixes and other miscellaneous changes I made I decided to separate them into separate PRs. Once this one is merged, I will create the other PR that contains the new additional imports and exports.

Note that this PR relies on a corresponding PR in Frodo-LIB under the same name as this PR

The list of changes include:

  • Fixed an issue with file paths on the Windows version of Frodo that were causing errors on imports due to the differences between Windows and Linux file paths.
  • Updated IDM exports to be formatted the same as normal exports instead of as raw data by putting the raw data into a type object. This included changing the names of the exports to have a type ‘idm’, such as ‘sync.idm.json’ instead of ‘sync.json’, in order to reflect this change.
  • Added option to import an entity from a single file from the full export using the -f flag in the config import command.
  • Added option to do env substitution on single entity IDM exports/imports, and put logic for handling it all in Frodo-Lib
  • Added option to export/import all IDM entities to/from a single file using the -a flag
  • Added option to include or not include metadata in IDM exports
  • Updated exports for agents, secrets, and variables to have a singular rather than plural type to be more consistent with other exports (see frodo-lib PR for more information on this change)
  • Fixed a bug where the agent list command wouldn’t work if the agent had no status
  • Fixed a bug where oauth2 and managed applications were exported with the wrong type in a full export
  • Fixed a bug where journey imports weren’t working when importing using -D flag
  • Standardized file extraction since it is used in multiple places (namely scripts, sync mappings, and, in a future PR, servers).
  • Removed progress indicators for script, esv variable and esv secret describe commands since they caused Frodo to never terminate.
  • Improved config imports to be able to import individual files based on the file type in the name instead of on directory structure (although directory structure is still used to determine whether to import globally or to know which realm to import to).
  • Updated tests. I updated the relevant existing recordings with all the changes from the future PR that includes the additional exports, so I don't anticipate having to update the recordings again when the future PR is made (although I didn't include any of the new recordings in this PR, so those will be in the future PR). Additionally, I updated all the import tests to instead use exports that can be easily updated with only a few commands (which are documented in the config-import.e2e.test.js file). All the tests should be passing.

@vscheuber vscheuber merged commit a11475d into rockcarver:main Nov 5, 2024
8 of 9 checks passed
@phalestrivir phalestrivir deleted the bugfix/export-import-fixes branch November 12, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants