Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vscheuber - this is a deeper change
MockForgeRockApi
still usesimport.meta.env
andreadFileSync
and I'm ignoring thatI'm not sure how precisely to test that the new package is fit for consumers. This may be something that you know better how to test. However, I think this version of the code should operate a lot better for packaging in binary with FrodoCLI.
We should also note that the typescript code comes up with a lot of "compile" errors - things which really don't follow the prescribed types. This isn't something I've introduced, but represents general risks around the code. Worth looking at longer-term.