Fix Classic Tests in Frodo-CLI #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mock matching for classic authentication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Polly setup code for the Frodo-CLI so that tests against classic deployments will work. A PR in frodo-cli (of the same name as this one) updates the tests accordingly.
The reason for the tests failing was due to authentication differences in classic deployments compared to platform deployments. In particular, cookies and token ids are used in classic deployments for authentication but were not being ignored when matching mock requests, so this PR fixes that issue. Additionally, more obfuscation is added to obfuscate the cookies and token ids in the requests/responses.