Skip to content

Commit

Permalink
Merge pull request #509 from activescott/fix/alerting-without-metrics…
Browse files Browse the repository at this point in the history
…-error

fix: An error would occur starting the smartnode when alerting was enabled but metrics was not
  • Loading branch information
jclapis authored Apr 25, 2024
2 parents 9f4d26c + 6273e32 commit cf91b5a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions rocketpool-cli/service/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,11 @@ func startService(c *cli.Context, ignoreConfigSuggestion bool) error {
if err != nil {
return err
}
}

// Update the Alertmanager configuration files even if metrics is disabled; as smartnode sends some alerts directly
alertingEnabled := cfg.Alertmanager.EnableAlerting.Value.(bool)
if alertingEnabled {
err = cfg.Alertmanager.UpdateConfigurationFiles(rp.ConfigPath())
if err != nil {
return err
Expand Down

0 comments on commit cf91b5a

Please sign in to comment.