Add node 'ENABLE_METRICS=true' environment override #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm shouldn't the environment variables be opaquely referenced in the config abstraction layer? |
Yes, they should, but I have to think harder about how to do that in a way that gives people fine-grained control over the metrics. I'll merge this for now so Ben can at least make it work properly, and robustify the metrics config in a later release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the #support channel on discord we had a discussion on enabling metrics for a standalone prometheus setup.
See rocket-pool/smartnode-install#67 for how this used to work.
However, it seems that this method broke on the node part, since that no longer starts the metrics server when it's disabled in the configuration file. This patch adds an override check to see if the
ENABLE_METRICSis set totrue, and if so starts it anyway.Alternatively this might be patched in through a separate configuration option, but I'll leave that to Joe :)