Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a TUI timestamp parameter for prices/balances submissions #502

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

0xfornax
Copy link
Member

@0xfornax 0xfornax commented Apr 18, 2024

This PR refactors prices and balances submissions previously based on locating event submissions to define the next submission time. The code now introduced a new TUI parameter that will be used to calculate when the next submission is due.

The default value for the new parameter is 1713420000 (April 18, 2024 6:00:00 AM UTC). Considering the 24-hour submission interval (on mainnet), after the Houston launch, oDAO nodes would submit new prices/balances every day for the block at 6:00:00 AM UTC (or, in case of a missed slot, the last proposed block before this time). This makes the submission process in a predictable way, as mandate by RPIP-35, and gets rid of event issues, especially during the transition to Houston.

Copy link
Contributor

@jshufro jshufro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Embracing golang's standard time library will simplify this logic and make it easier to read.

Otherwise, lgtm.

I only commented on balances, but the rpl price code is much the same and all the same comments apply.

rocketpool/watchtower/submit-network-balances.go Outdated Show resolved Hide resolved
rocketpool/watchtower/submit-network-balances.go Outdated Show resolved Hide resolved
rocketpool/watchtower/submit-network-balances.go Outdated Show resolved Hide resolved
rocketpool/watchtower/submit-network-balances.go Outdated Show resolved Hide resolved
@0xfornax 0xfornax merged commit 93ada7c into houston Apr 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants