Added "is RPL Locking Allowed" check to every PDAOCanProposeXYZ function
#506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add is RPL Locking Allowed check to proposeSetting
add is RPL Locking Allowed check to proposeSecurityCouncilInvite
add RPL Locking Allowed check to proposeRecurringSpend
add RPL Locking Allowed check to proposeSecurityCouncilReplace
0xfornax
reviewed
Apr 21, 2024
| var wg errgroup.Group | ||
|
|
||
| // Get is RPL locking allowed | ||
| wg.Go(func() error { |
There was a problem hiding this comment.
You usually want to use goroutines when starting multiple queries at the same time. If you have only one query then you don't need to use threads.
There was a problem hiding this comment.
Thanks for the tip! I've fixed the usage of goroutines.
0xfornax
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDAO functions edited:
Haven't tested these 3 yet:- Propose Sec Council Kick- Propose Recurring Spend Update- Propose Sec Council Updatefixed usage of goroutines per Fornax's suggestion!