Addressing rocket-pool/smartnode#601 on v2 branch #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you accidentally included an extra commit in this PR. It should just be the mev-boost issue, but has a commit intended to implement partial wallet recovery. |
|
You're right - not sure how that happened. I'll fix this. |
Addressing rocket-pool#601 on v2 branch
SolezOfScience
force-pushed
the
feature/v2/feature/smartnode-issues-601
branch
from
5085b10
to
0ef750f
Compare
jshufro
reviewed
Sep 9, 2024
| @@ -19,6 +19,7 @@ services: | |||
| - NETWORK={{.Network}} | |||
| - MEV_BOOST_PORT={{.MevBoost.Port}} | |||
| - MEV_BOOST_RELAYS={{.MevBoost.GetRelayString}} | |||
| - MEV_BOOST_ADDITIONAL_FLAGS={{.MevBoost.AdditionalFlags}} | |||
There was a problem hiding this comment.
I don't see this being added to the config struct in this pr. I'm assuming it was already cherry-picked in to v2?
jshufro
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting the changes made as part of rocket-pool/smartnode-install#135 to the v2 branch.