Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] Snapshot field updated from string -> int64 #695

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

0xfornax
Copy link
Member

Replicate #691 on v2.

@0xfornax 0xfornax changed the title Snapshot field updated from string -> int64 [V2] Snapshot field updated from string -> int64 Oct 31, 2024
Copy link

Coverage Report

Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/common/voting 0.00% (ø)
github.com/rocket-pool/smartnode/v2/shared/types 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/common/voting/utils.go 0.00% (ø) 704 0 704
github.com/rocket-pool/smartnode/v2/shared/types/voting.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@0xfornax 0xfornax merged commit 46ad411 into v2 Nov 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant