Detect original filetype ftdetect #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detection and filetype setting are done in ftdetect scripts filetype is set to subtype.epuppet so ftplugin and syntax file loading is done by (n)vim owns scripts (ftplugin.vim and syntax/synload.vim) Added more test to detect if g:epuppet_default_subtype is defined in .vimrc
If using ``` 'for': ['puppet', 'epuppet'] ``` vim-plug load ftdetect/puppet.vim, that set filetype to 'subtype.epuppet' then as this does not strictly match 'epuppet' vim-plug remove vim-puppet from &rtp and syntax and ftplugin file could not be loaded. The solution is to add a wildcard ``` 'for': ['puppet', '*epuppet'] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've redone the subtype detection completely in ftdetect.[vim|lua].
This just set the filetype as 'subtype.type' and let vim loads ftplugins and syntax file for both filetype.
I didn't add new versions of vim to the workflow of this MR but ran tests on a separate branch, you can see the results there: https://github.com/shadowwa/vim-puppet/actions/runs/10981471798
With this, I have syntax highlighting + linting from ALE + lsp from COC for the subtype lanquage.
this should close #154 and #148