Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes missing prefixes in .bs and d.bs files for interfaces, enums, and constants #80

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Fixes missing prefixes in .bs and d.bs files for interfaces, enums, and constants #80

merged 5 commits into from
Nov 25, 2024

Conversation

TwitchBronBron
Copy link
Member

Fixes a pretty big bug where ropm doesn't understand root-level enums, interfaces, or constants!

  • now properly wraps top-level enums, constants, and interfaces with the prefixed namespaces
  • prefixes interface and class member types with the prefix namespaces

@TwitchBronBron TwitchBronBron added the create-package create a temporary npm package on every commit label Nov 21, 2024
@rokucommunity-bot
Copy link

Hey there! I just built a new temporary npm package based on 6b1cefb. You can download it here or install it by running the following command:

npm install https://github.com/rokucommunity/ropm/releases/download/v0.0.0-packages/ropm-0.10.27-fix-enum-iface-const-prefixing.20241121211412.tgz

@TwitchBronBron TwitchBronBron merged commit 062faf7 into master Nov 25, 2024
12 checks passed
@TwitchBronBron TwitchBronBron deleted the fix-enum-iface-const-prefixing branch November 25, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdp chrisdp chrisdp approved these changes

Assignees
No one assigned
Labels
create-package create a temporary npm package on every commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TwitchBronBron @chrisdp