Improve error on local EL blobs lookup (Consensys#8826)

rolfyone · Nov 6, 2024 · b5d4cbc · b5d4cbc
1 parent cedae8a
commit b5d4cbc
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/...c/main/java/tech/pegasys/teku/statetransition/util/BlockBlobSidecarsTrackersPoolImpl.java b/...c/main/java/tech/pegasys/teku/statetransition/util/BlockBlobSidecarsTrackersPoolImpl.java
@@ -14,6 +14,7 @@
 package tech.pegasys.teku.statetransition.util;
 
 import static com.google.common.base.Preconditions.checkArgument;
+import static tech.pegasys.teku.infrastructure.exceptions.ExceptionUtil.getRootCauseMessage;
 import static tech.pegasys.teku.infrastructure.time.TimeUtilities.secondsToMillis;
 import static tech.pegasys.teku.statetransition.blobs.BlobSidecarManager.RemoteOrigin.LOCAL_EL;
 import static tech.pegasys.teku.statetransition.blobs.BlobSidecarManager.RemoteOrigin.LOCAL_PROPOSAL;
@@ -33,7 +34,6 @@
 import java.util.function.Supplier;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
-import org.apache.commons.lang3.exception.ExceptionUtils;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 import org.apache.tuweni.bytes.Bytes32;
@@ -508,10 +508,7 @@ private BlockBlobSidecarsTracker internalOnNewBlock(
                 // Let's try now
                 if (!existingTracker.isLocalElFetchTriggered() && !existingTracker.isCompleted()) {
                   fetchMissingContentFromLocalEL(slotAndBlockRoot)
-                      .finish(
-                          error ->
-                              LOG.error(
-                                  "An error occurred while attempting to fetch blobs via local EL"));
+                      .finish(this::logLocalElBlobsLookupFailure);
                 }
               }
             });
@@ -597,18 +594,18 @@ private void onFirstSeen(
         .runAfterDelay(
             () ->
                 this.fetchMissingContentFromLocalEL(slotAndBlockRoot)
-                    .handleException(
-                        error ->
-                            LOG.warn(
-                                "Local EL blobs lookup failed: {}",
-                                ExceptionUtils.getRootCauseMessage(error)))
+                    .handleException(this::logLocalElBlobsLookupFailure)
                     .thenRun(() -> this.fetchMissingContentFromRemotePeers(slotAndBlockRoot)),
             fetchDelay)
         .finish(
             error ->
                 LOG.error("An error occurred while attempting to fetch missing blobs.", error));
   }
 
+  private void logLocalElBlobsLookupFailure(final Throwable error) {
+    LOG.warn("Local EL blobs lookup failed: {}", getRootCauseMessage(error));
+  }
+
   @VisibleForTesting
   Duration calculateFetchDelay(final SlotAndBlockRoot slotAndBlockRoot) {
     final UInt64 slot = slotAndBlockRoot.getSlot();