Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interview): add new api & deprecation marks to the old #2272

Merged
merged 2 commits into from
Aug 26, 2023

Conversation

aaliakseyenka
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

💡 Background and solution

Adds new api & marks deprecated api

@valerydluski
Copy link
Contributor

Approval with a recommendation to create an issue for the removal of deprecated methods in the server at some point

Base automatically changed from interview-feedback-2 to master August 26, 2023 10:45
@github-actions
Copy link

📦 Next.js Bundle Analysis for client

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 148.87 KB (🟡 +4 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fifty-four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (500 KB)
/ 291.83 KB 440.71 KB 88.14% (🟡 +0.05%)
/404 203.86 KB 352.73 KB 70.55% (🟡 +0.04%)
/admin/courses 371.6 KB 520.47 KB 104.09% (🟡 +0.05%)
/admin/disciplines 311.53 KB 460.4 KB 92.08% (🟡 +0.05%)
/admin/discord-server 344.16 KB 493.04 KB 98.61% (🟡 +0.04%)
/admin/events 344.75 KB 493.63 KB 98.73% (🟡 +0.04%)
/admin/mentor-registry 368.67 KB 517.54 KB 103.51% (🟡 +0.04%)
/admin/notifications 377.36 KB 526.24 KB 105.25% (🟡 +0.04%)
/admin/prompts 309.92 KB 458.8 KB 91.76% (🟡 +0.05%)
/admin/registrations 321.92 KB 470.79 KB 94.16% (🟡 +0.04%)
/admin/tasks 424.31 KB 573.18 KB 114.64% (🟡 +0.04%)
/admin/user-group 369.24 KB 518.12 KB 103.62% (🟡 +0.05%)
/admin/users 260.25 KB 409.12 KB 81.82% (🟡 +0.05%)
/applicants 314.08 KB 462.95 KB 92.59% (🟡 +0.05%)
/course/admin/cross-check-table 422.41 KB 571.29 KB 114.26% (🟡 +0.04%)
/course/admin/events 426.36 KB 575.23 KB 115.05% (🟡 +0.04%)
/course/admin/interviews 370.54 KB 519.41 KB 103.88% (🟡 +0.05%)
/course/admin/mentors 380.34 KB 529.22 KB 105.84% (🟡 +0.05%)
/course/admin/stage-interviews 372.08 KB 520.95 KB 104.19% (🟡 +0.04%)
/course/admin/students 384.02 KB 532.89 KB 106.58% (🟡 +0.04%)
/course/admin/tasks 402.01 KB 550.88 KB 110.18% (🟡 +0.04%)
/course/admin/users 370.58 KB 519.46 KB 103.89% (🟡 +0.05%)
/course/interview/[type]/feedback 282.89 KB 431.77 KB 86.35% (🟡 +0.05%)
/course/mentor/auto-confirm 224.57 KB 373.45 KB 74.69% (🟡 +0.04%)
/course/mentor/confirm 287.15 KB 436.02 KB 87.20% (🟡 +0.05%)
/course/mentor/dashboard 389.47 KB 538.35 KB 107.67% (🟡 +0.04%)
/course/mentor/expel-student 295.07 KB 443.94 KB 88.79% (🟡 +0.04%)
/course/mentor/feedback 281.78 KB 430.65 KB 86.13% (🟡 +0.05%)
/course/mentor/interview-technical-screening 263.17 KB 412.05 KB 82.41% (🟡 +0.04%)
/course/mentor/interview-wait-list 325.03 KB 473.9 KB 94.78% (🟡 +0.05%)
/course/mentor/interviews 341.2 KB 490.07 KB 98.01% (🟡 +0.05%)
/course/mentor/students 230.59 KB 379.46 KB 75.89% (🟡 +0.05%)
/course/schedule 454.08 KB 602.96 KB 120.59% (🟡 +0.05%)
/course/score 337.33 KB 486.21 KB 97.24% (🟡 +0.05%)
/course/student/auto-test 367.37 KB 516.24 KB 103.25% (🟡 +0.04%)
/course/student/auto-test/task 367.28 KB 516.16 KB 103.23% (🟡 +0.05%)
/course/student/cross-check-review 407.15 KB 556.02 KB 111.20% (🟡 +0.05%)
/course/student/cross-check-submit 422.36 KB 571.23 KB 114.25% (🟡 +0.04%)
/course/student/dashboard 386.94 KB 535.81 KB 107.16% (🟡 +0.05%)
/course/student/interviews 282.1 KB 430.98 KB 86.20% (🟡 +0.04%)
/course/submit-scores 404.67 KB 553.55 KB 110.71% (🟡 +0.04%)
/course/team-distributions 369.36 KB 518.24 KB 103.65% (🟡 +0.04%)
/course/teams 413.4 KB 562.28 KB 112.46% (🟡 +0.04%)
/cv/[uuid] 245.96 KB 394.84 KB 78.97% (🟡 +0.05%)
/cv/edit 333.93 KB 482.8 KB 96.56% (🟡 +0.05%)
/gratitude 288.82 KB 437.7 KB 87.54% (🟡 +0.05%)
/heroes 287.95 KB 436.82 KB 87.36% (🟡 +0.05%)
/job 221.84 KB 370.71 KB 74.14% (🟡 +0.05%)
/profile 395.18 KB 544.05 KB 108.81% (🟡 +0.05%)
/profile/connection-confirmed 249.62 KB 398.49 KB 79.70% (🟡 +0.05%)
/profile/notifications 323.8 KB 472.68 KB 94.54% (🟡 +0.04%)
/registry/epamlearningjs 285.26 KB 434.13 KB 86.83% (🟡 +0.04%)
/registry/mentor 345.88 KB 494.76 KB 98.95% (🟡 +0.05%)
/registry/student 345.88 KB 494.75 KB 98.95% (🟡 +0.05%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@aaliakseyenka
Copy link
Contributor Author

#2281

@aaliakseyenka aaliakseyenka merged commit 5f32cfe into master Aug 26, 2023
6 checks passed
@aaliakseyenka aaliakseyenka deleted the interview-feedback-3 branch August 26, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants