Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent behaviour across adapters with read types and "create" command #432

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix inconsistent behaviour across adapters with read types and "create" command #432

wants to merge 2 commits into from

Commits on Oct 27, 2024

  1. Add tests replicating the issue with custom types

    @katafrakt
    katafrakt committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    52bd555 View commit details
    Browse the repository at this point in the history

  2. Use dataset to fetch record after insert 

    Similarily to what Update command do, use `dataset` to load the tuple
after `insert` in Create command. This way it loads "raw" data, without
applying read types yet. So when tuples are passed into `finalize` hook,
it can properly apply these read types.
    @katafrakt
    katafrakt committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    c4fc450 View commit details
    Browse the repository at this point in the history