Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Add MariaDB healthcheck recommendation to Docker Compose config #1278

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

adamantike
Copy link
Collaborator

This commit adds a healthcheck configuration to the MariaDB service in the Docker Compose example configuration. The healthcheck script is a simple shell script that checks if the MariaDB server is ready to accept connections.

The application will wait for the MariaDB service to be healthy before starting the application service. This should solve issues where the database takes longer to start than the application, and logs some Something went horribly wrong with our database errors.

This change also stops recommending the linuxserver/mariadb image as an alternative. We have had users that change the image because of the first time run triggering those errors, but the linuxserver/mariadb image requires a different configuration that could be confusing for new users (e.g. volume mountpoint needs to be /config instead of /var/lib/mysql).

This commit adds a healthcheck configuration to the MariaDB service in the
Docker Compose example configuration. The healthcheck script is a simple
shell script that checks if the MariaDB server is ready to accept connections.

The application will wait for the MariaDB service to be healthy before
starting the application service. This should solve issues where the
database takes longer to start than the application, and logs some
`Something went horribly wrong with our database` errors.

This change also stops recommending the `linuxserver/mariadb` image as
an alternative. We have had users that change the image because of the
first time run triggering those errors, but the `linuxserver/mariadb`
image requires a different configuration that could be confusing for new
users (e.g. volume mountpoint needs to be `/config` instead of
`/var/lib/mysql`).
@Moonraka
Copy link

Moonraka commented Nov 6, 2024

This worked when I tested it. I was having issues when using the linuxserver and now everything works as it should using the main mariadb server. (Mr Moon in discord)

@adamantike adamantike merged commit a57d5b3 into master Nov 15, 2024
6 checks passed
@adamantike adamantike deleted the misc/add-mariadb-healthcheck-recommendation branch November 15, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants