Drop Game Link to download and view. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives the ability to drop a game link from the halite website, and it will download and load the game, the game will be saved in /games folder. Probably not the best javascript ever as i only learnt yesteday, also the url to download the game includes a player id, This is tsadmirals but any seem to work, no login required.
|
It seems to break for me the 2nd time you do it. How about you? |
|
I just cloned a fresh copy from my repository and it seems to be working here, I can watch the game 3-4 times no problem, the same game several times in a row, or alternating between a couple of games, I even tried loading local games in between and it seems to be solid. I am running Linux, and electron is running locally installed, not sure if that would make a difference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives the ability to drop a game link from the halite website, and it
will download and load the game, the game will be saved in /games
folder.
Probably not the best javascript ever as i only started learning yesterday, also
the url to download the game includes a player id, This is tsadmirals,
but any seem to work, no login required.
I'm not sure if people would want to download the game, but that was how I got it to work... also I don't check to see if the game is already there.