Add logging to Flo library #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vizsatiz
reviewed
Sep 13, 2024
vizsatiz
requested changes
Sep 17, 2024
vizsatiz
previously approved these changes
Sep 17, 2024
vizsatiz
reviewed
Sep 18, 2024
flo_ai/common/README.md
Outdated
|
|
||
| FLO_LOG_LEVEL_COMMON: Controls the level for the "CommonLogs" logger. | ||
| FLO_LOG_LEVEL_BUILDER: Controls the level for the "BuilderLogs" logger. | ||
| FLO_LOG_LEVEL_SESSION: Controls the level for the "SessionLogs" logger. |
There was a problem hiding this comment.
Maybe we can add the definition of what commonlogs, builderlogs and sessionlogs are in this readme
flo_ai/common/README.md
Outdated
| export FLO_LOG_LEVEL_SESSION=WARNING | ||
|
|
||
|
|
||
| 2. FloSession Creation: |
flo_ai/common/README.md
Outdated
| @@ -0,0 +1,67 @@ | |||
| # Understanding Log Levels | |||
There was a problem hiding this comment.
You can probably copy paste this to an AI prompt and make it better markdown
flo_ai/common/flo.log
Outdated
There was a problem hiding this comment.
Remove this file, add the *.log in .gitignore
flo_ai/core.py
Outdated
| def build(session: FloSession, yaml: str): | ||
| return Flo(session, to_supervised_team(yaml)) | ||
| def build(session: FloSession, yaml: str, log_level: str = "INFO"): | ||
| FloLogger.set_log_level("BUILDER", log_level) |
| from langchain.schema import AgentAction, AgentFinish, LLMResult | ||
| from flo_ai.common.flo_logger import get_logger | ||
|
|
||
| class FloCallbackHandler(BaseCallbackHandler): |
There was a problem hiding this comment.
Why do we have both this and langchain handler ?
|
@thomastomy5 Overall the design is really good! |
vizsatiz
reviewed
Sep 18, 2024
flo_ai/core.py
Outdated
| self.runnable: ExecutableFlo = build_supervised_team(session, config) | ||
|
|
||
| FloLogger.set_log_level("COMMON", log_level) | ||
| FloLogger.set_log_level("BUILDER", log_level) |
There was a problem hiding this comment.
Why dont you use set_global_log_level?
vizsatiz
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.