🩹 fix(patch): windows bootstrap path resolution #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
@roots/bud-framework
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First error to fix in order to provide native support for Windows. We have to start here because it happens during bootstrapping, so not much of the application can even run.
A similar fix may also need to be applied to
@roots/bud-framework/moduleand@roots/fs. Not sure.From vite
They are calling
path.posix.normalize, which is the same asnormalizefromnode:path/posix:https://github.com/vitejs/vite/blob/33d3cca78607e14e4d0b13e7012d065a94d184b1/packages/vite/src/node/utils.ts#L62-L64
Do we also need to prepend the
/in windows? Don't know yet. See:https://github.com/vitejs/vite/blob/33d3cca78607e14e4d0b13e7012d065a94d184b1/packages/vite/src/node/utils.ts#L63C30-L63C33
Type of change
PATCH: backwards compatible change