Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump schema version from 2 to 3 #2645

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

joshuafredrickson
Copy link
Contributor

Version 3 is now supported in WordPress 6.6.

Reference: https://developer.wordpress.org/block-editor/reference-guides/theme-json-reference/theme-json-living/

Migrating from v2 to v3: https://developer.wordpress.org/block-editor/reference-guides/theme-json-reference/theme-json-migrations/#migrating-from-v2-to-v3

Type of change

PATCH: backwards compatible change

This doesn't appear to break anything. Although, there are migration steps in the link above that add two default values: settings.typography.defaultFontSizes and settings.spacing.defaultSpacingSizes.

@kellymears
Copy link
Member

Sorry for the delay! This looks great & thank you for your work on it.

Looks like the tests are failing, which is good. Could you run the following two commands and commit the new snapshots?

yarn @bud test unit --update
yarn @bud test integration --update

@joshuafredrickson
Copy link
Contributor Author

Sure thing!
Ran them and committed, but bumped into an AWS access key error on tests/reproductions/issue-2574.test.ts.

@stevencamilleri-g2m
Copy link

Any updates on whether this will be implemented soon? 6.7 will be released today and it's quite important to be using theme.json schema version 3 to have access to new properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants