Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dep for vignette building #35

Closed
wants to merge 1 commit into from
Closed

Conversation

maelle
Copy link
Member

@maelle maelle commented Dec 8, 2023

We see a docs building failure on https://ropensci.r-universe.dev/builds

I'd recommend running desc::desc_normalize() to have the dependencies alphabetically ordered 💅 (really a detail)

@bcjaeger
Copy link
Collaborator

bcjaeger commented Dec 8, 2023

Thank you! Including the tidyverse in a vignette was an oversight on my part. I dropped it and then ran desc::desc_normalize to organize DESCRIPTION. Hoping this fixes the build errors

@bcjaeger
Copy link
Collaborator

bcjaeger commented Dec 8, 2023

I see checks on this repo are passing now, but there seems to be some trouble building the source here: https://github.com/r-universe/ropensci/actions/runs/7143616638

I have not seen this problem before. Is there anything I can do to resolve this?

update: this was fixed a few hours later.

@bcjaeger
Copy link
Collaborator

I'm assuming no news is good news on this. Please feel free to re-open this if you'd like to discuss further!

@bcjaeger bcjaeger closed this Dec 11, 2023
@maelle
Copy link
Member Author

maelle commented Dec 12, 2023

Yes sorry for the delay! The webassembly builds don't work for all packages just yet. For context: https://ropensci.org/blog/2023/11/17/runiverse-wasm/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants