Merge pull request #122 from b-rodrigues/nix-build-set-r-libs-user

- `nix_build()`: another guardrail for run-time purity of Nixpkgs R
ropensci · Jan 31, 2024 · c8d98a0 · c8d98a0
2 parents 4d89dfb + b5c3666
commit c8d98a0
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 5 deletions.
diff --git a/R/nix_build.R b/R/nix_build.R
@@ -28,6 +28,9 @@ nix_build <- function(project_path = ".",
                       exec_mode = c("blocking", "non-blocking")) {
   # if nix store is not PATH variable; e.g. on macOS (system's) RStudio
   PATH <- set_nix_path()
+  if (isTRUE(nzchar(Sys.getenv("NIX_STORE")))) {
+    remove_r_libs_user()
+  }
   has_nix_build <- nix_build_installed() # TRUE if yes, FALSE if no
   nix_file <- file.path(project_path, "default.nix")
 
@@ -72,6 +75,17 @@ nix_build <- function(project_path = ".",
   return(invisible(proc))
 }
 
+#' @noRd
+remove_r_libs_user <- function() {
+  current_paths <- .libPaths()
+  userlib_paths <- Sys.getenv("R_LIBS_USER")
+  user_dir <- grep(paste(userlib_paths, collapse = "|"), current_paths)
+  new_paths <- current_paths[-user_dir]
+  # sets new library path without user library, making nix-R pure at 
+  # run-time
+  invisible(.libPaths(new_paths))
+}
+
 #' @noRd
 poll_sys_proc_blocking <- function(cmd, proc,
                                    what = c("nix-build", "expr")) {

diff --git a/dev/config_fusen.yaml b/dev/config_fusen.yaml
@@ -210,7 +210,7 @@ flat_nix_build.Rmd:
   path: dev/flat_nix_build.Rmd
   state: active
   R: R/nix_build.R
-  tests: [tests/testthat/test-nix_build.R]
+  tests: tests/testthat/test-nix_build.R
   vignettes: []
   inflate:
     flat_file: dev/flat_nix_build.Rmd

diff --git a/dev/flat_nix_build.Rmd b/dev/flat_nix_build.Rmd
@@ -41,6 +41,9 @@ nix_build <- function(project_path = ".",
                       exec_mode = c("blocking", "non-blocking")) {
   # if nix store is not PATH variable; e.g. on macOS (system's) RStudio
   PATH <- set_nix_path()
+  if (isTRUE(nzchar(Sys.getenv("NIX_STORE")))) {
+    remove_r_libs_user()
+  }
   has_nix_build <- nix_build_installed() # TRUE if yes, FALSE if no
   nix_file <- file.path(project_path, "default.nix")
 
@@ -85,6 +88,17 @@ nix_build <- function(project_path = ".",
   return(invisible(proc))
 }
 
+#' @noRd
+remove_r_libs_user <- function() {
+  current_paths <- .libPaths()
+  userlib_paths <- Sys.getenv("R_LIBS_USER")
+  user_dir <- grep(paste(userlib_paths, collapse = "|"), current_paths)
+  new_paths <- current_paths[-user_dir]
+  # sets new library path without user library, making nix-R pure at 
+  # run-time
+  invisible(.libPaths(new_paths))
+}
+
 #' @noRd
 poll_sys_proc_blocking <- function(cmd, proc,
                                    what = c("nix-build", "expr")) {
@@ -151,9 +165,9 @@ testthat::test_that("Testing that `nix_build()` builds derivation", {
   
   skip_if_not(nix_shell_available())
   
-  skip_on_covr()
+  # skip_on_covr()
 
-  path_subshell <- "."
+  path_subshell <- tempdir()
 
   rix_init(
     project_path = path_subshell,

diff --git a/tests/testthat/test-nix_build.R b/tests/testthat/test-nix_build.R
@@ -5,9 +5,9 @@ testthat::test_that("Testing that `nix_build()` builds derivation", {
 
   skip_if_not(nix_shell_available())
 
-  skip_on_covr()
+  # skip_on_covr()
 
-  path_subshell <- "."
+  path_subshell <- tempdir()
 
   rix_init(
     project_path = path_subshell,