Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoC annual review #941

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

CoC annual review #941

wants to merge 9 commits into from

Conversation

yabellini
Copy link
Member

No description provided.

@yabellini yabellini added the blog post Blog posts to be published when merged label Jan 10, 2025
yabellini
yabellini commented Jan 13, 2025
View reviewed changes
Copy link
Member Author

@yabellini yabellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finishing update

content/blog/2025-01-20-conduct2024/index.md Outdated Show resolved Hide resolved
content/blog/2025-01-20-conduct2024/index.md Outdated Show resolved Hide resolved
content/blog/2025-01-20-conduct2024/index.md Outdated Show resolved Hide resolved
content/blog/2025-01-20-conduct2024/index.md Outdated Show resolved Hide resolved
content/blog/2025-01-20-conduct2024/index.md Show resolved Hide resolved
@yabellini yabellini marked this pull request as ready for review January 13, 2025 18:41
@yabellini
Copy link
Member Author

Now I need your review on the annual review and update blog post @nmorandeira @mpadge. Again, the date is a suggestion we can move it if we need more time. Thanks!

mpadge
mpadge approved these changes Jan 14, 2025
View reviewed changes
content/blog/2025-01-20-conduct2024/index.md Outdated Show resolved Hide resolved
@yabellini @mpadge @maelle
Apply suggestions from code review
628079f 
Co-authored-by: mark padgham <mark.padgham@email.com>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
nmorandeira
nmorandeira reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@nmorandeira nmorandeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yani! I added very minor edits

content/blog/2025-01-20-conduct2024/index.md Outdated Show resolved Hide resolved
content/blog/2025-01-20-conduct2024/index.md Show resolved Hide resolved
content/blog/2025-01-20-conduct2024/index.md Outdated Show resolved Hide resolved
@yabellini @nmorandeira
Update content/blog/2025-01-20-conduct2024/index.md
ab4be0f 
Co-authored-by: Natalia Morandeira <nmorandeira@unsam.edu.ar>
@yabellini
Copy link
Member Author

Thank you @nmorandeira !

@mpadge
Copy link
Member

mpadge commented Jan 21, 2025

@yabellini Quite a few suggestions from me once again, but all of them very minor. Thanks for the great work!

yabellini
yabellini commented Jan 21, 2025
View reviewed changes
Copy link
Member Author

@yabellini yabellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add link to CoC

content/blog/2025-01-20-conduct2024/index.md Outdated Show resolved Hide resolved
@yabellini @mpadge
Apply suggestions from code review
66bfbc7 
Thank you @mpadge!

Co-authored-by: mark padgham <mark.padgham@email.com>
@mpadge mpadge self-requested a review January 21, 2025 12:37
mpadge
mpadge approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yabellini, I'm re-approving the PR now

yabellini
yabellini commented Jan 21, 2025
View reviewed changes
Copy link
Member Author

@yabellini yabellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrasing as suggested by @mpadge

content/blog/2025-01-20-conduct2024/index.md Outdated Show resolved Hide resolved
content/blog/2025-01-20-conduct2024/index.md Outdated Show resolved Hide resolved
content/blog/2025-01-20-conduct2024/index.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maelle maelle maelle left review comments

@nmorandeira nmorandeira nmorandeira left review comments

@mpadge mpadge mpadge approved these changes

Assignees

@yabellini yabellini

@mpadge mpadge

Labels
blog post Blog posts to be published when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yabellini @mpadge @nmorandeira @maelle