Avoid testthat deprecated features + upkeep #747
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #749
Basically, this updates the Roxygen2 version and use
"_PACKAGE"
https://www.tidyverse.org/blog/2024/01/roxygen2-7-3-0/I know this may be hard to review, but I tried to keep all commits self-contained. Happy to split in many PRs if it helps.
usethis::use_github_action()
(remove pkgdown action, not needed due to Ropensci publishing site)testthat::with_mock()
as it is now deprecated and replace it withtestthat::local_mocked_bindings()
expect_snapshot()
, and for testingknit_print()
, I usedcat()
to only capture output.I verified manually that the new output is the same as the old.
As you see, I didn't modify much under
R/
except for updating to newer (dplyr > 1.0, tidyr >1.0) functions.Happy to answer questions