-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add funtions to cal angle to prevent sideroads getting values of main road #524
Conversation
wangzhao0217
commented
Sep 4, 2023
- update funtions get_vector and calculate_angle
- corr_line_geometry is not exist
Hi @Robinlovelace
However, it is still not working, will keep fixing it. |
Thanks Zhao, will take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Zhao. Do you have any results showing the removal of high values on side roads?
R/rnet_join.R
Outdated
for(i in sum_cols) { | ||
# TODO: deduplicate | ||
length_y = as.numeric(sf::st_length(rnet_y)) | ||
mask <- (res_sf$angle < 15) | (res_sf$angle > 160) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are hard coded. At some point it would be good to make these available as arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are hard coded. At some point it would be good to make these available as arguments.
Got it, Robin. Sorry at the moment there is a bug in the code, I am working on it to solve it. (Switching from Python to R for programming is tough that I thought)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's tricky. Keep up the good work and no worries about making these hardcoded values available as arguments, can add later..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Robinlovelace got some results, catch up with you tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Let's discuss and hopefully merge this today @wangzhao0217
will make new pr |
Sounds good, looking forward to reviewing it and seeing the results. |