Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PID] Add support for saving i-term when PID is reset #180

Open
wants to merge 6 commits into
base: ros2-master
Choose a base branch
from

Conversation

destogl
Copy link
Member

@destogl destogl commented Feb 11, 2024

Saves integral term on reset to maintain steady state offset output.
This is required for controlling of system without integral part to achieve correct steady-state output.
If intergral term is reset for some time there will be incorrect output in steady-state. This features avoids such situations and makes btter performance.

Whalex451 and others added 4 commits February 11, 2024 09:06
Added save_iterm_ to PID gains
Added save_iterm() and clear_saved_iterm() methods to update and clear save integral term
Cleared saved integral term in constructor
Called save_iterm() in reset() method
Added saved integral term to PID output
Simplified saving of integral term
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
Copy link

@olivier-stasse olivier-stasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no test if this parameter has the desired effect. Could you please add any? e.g., to gainSettingCopyPIDTest or add a new one..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants