Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

propagate gazebo remapping and other arguments to the controller node #396

Merged
merged 1 commit into from
Aug 23, 2024
Merged

propagate gazebo remapping and other arguments to the controller node #396

merged 1 commit into from
Aug 23, 2024

Conversation

saikishor
Copy link
Member

Changes to have remapping. Similar approach to: ros-controls/ros2_control#1712

@ahcorde ahcorde merged commit cbdd3a3 into ros-controls:master Aug 23, 2024
5 checks passed
@ahcorde
Copy link
Collaborator

ahcorde commented Aug 23, 2024

@saikishor should we backport this to other distros?

@saikishor
Copy link
Member Author

@saikishor should we backport this to other distros?

Yes, It would be needed for Jazzy

1 similar comment
@saikishor
Copy link
Member Author

@saikishor should we backport this to other distros?

Yes, It would be needed for Jazzy

@ahcorde
Copy link
Collaborator

ahcorde commented Aug 23, 2024

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 23, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 23, 2024
@saikishor @mergify
propagate gazebo remapping and other arguments to the controller node (…
5cb5efa 
…#396)

(cherry picked from commit cbdd3a3)
@mergify mergify bot mentioned this pull request Aug 23, 2024
Merged
ahcorde pushed a commit that referenced this pull request Aug 23, 2024
@mergify @saikishor
propagate gazebo remapping and other arguments to the controller node (…
a9bcaa2 
…#396) (#397)

(cherry picked from commit cbdd3a3)

Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@christophfroehlich christophfroehlich Awaiting requested review from christophfroehlich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saikishor @ahcorde