Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add jazzy 🚀 #165

Merged
merged 16 commits into from
May 8, 2024
Merged

[CI] Add jazzy 🚀 #165

merged 16 commits into from
May 8, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Apr 25, 2024

  • Jazzy jobs + readme
  • because all of the repos file are empty, there was no difference between binary and semi-binary. So I deleted also the semi-binary workflow file.

Jobs for jazzy-main are failing, but jazzy-testing works fine already.

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.37%. Comparing base (b6552e4) to head (05145a4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   76.37%   76.37%           
=======================================
  Files           7        7           
  Lines         237      237           
  Branches       40       40           
=======================================
  Hits          181      181           
  Misses         26       26           
  Partials       30       30           
Flag Coverage Δ
unittests 76.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good to me :)

realtime_tools-not-released.jazzy.repos Outdated Show resolved Hide resolved
realtime_tools.jazzy.repos Outdated Show resolved Hide resolved
@christophfroehlich
Copy link
Contributor Author

christophfroehlich commented Apr 29, 2024

@saikishor I haven't questioned this, just added jazzy. But you are right, it works without specifying a repos file. And because all of them are empty, there was no difference between binary and semi-binary. So I deleted also the semi-binary workflow file.

Edit: nope, only ICI works without the repos file. I have to change the other imported workflows from ros2_control_ci to work without a given repos file.

@christophfroehlich christophfroehlich marked this pull request as draft April 29, 2024 06:09
@christophfroehlich christophfroehlich marked this pull request as ready for review April 29, 2024 12:30
@github-actions github-actions bot requested review from jaron-l and mcbed April 29, 2024 12:30
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. Thanks for the changes :)

.github/workflows/abi-compatibility.yml Outdated Show resolved Hide resolved
.github/workflows/binary-build.yml Outdated Show resolved Hide resolved
.github/workflows/debian-build.yml Outdated Show resolved Hide resolved
.github/workflows/rhel-semi-binary-build.yml Outdated Show resolved Hide resolved
@christophfroehlich christophfroehlich merged commit cb528eb into master May 8, 2024
24 of 26 checks passed
@christophfroehlich christophfroehlich deleted the ci_jazzy branch May 8, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants