Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include <functional> in realtime_box_best_effort #173

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented Sep 30, 2024

Since the RealTimeBoxBestEffort uses std::functions to set and get pointer types (which is great), it should also include <functional>.

Note: This doesn't explode in the tests, since there is gmock included, which somewhere includes on the way.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.36%. Comparing base (10fa880) to head (8090c41).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   75.36%   75.36%           
=======================================
  Files           8        8           
  Lines         341      341           
  Branches       62       62           
=======================================
  Hits          257      257           
  Misses         50       50           
  Partials       34       34           
Flag Coverage Δ
unittests 75.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/realtime_tools/realtime_box_best_effort.h 87.87% <ø> (ø)

@christophfroehlich christophfroehlich merged commit a11e9cf into ros-controls:master Oct 30, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants