Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document calculate_dynamics of mock hardware #1490

Closed
christophfroehlich opened this issue Apr 18, 2024 · 3 comments
Closed

Document calculate_dynamics of mock hardware #1490

christophfroehlich opened this issue Apr 18, 2024 · 3 comments

Comments

@christophfroehlich
Copy link
Contributor

Document calculate_dynamics of mock hardware here.

@emp0012
Copy link

emp0012 commented Apr 23, 2024

Is the parameter "calculate_dynamics" required when we use a velocity controller with mock components?

Edit: It is a required parameter. Why does this exist? Shouldn't it be obvious that dynamics must be calculated if one used a velocity controller?

@christophfroehlich
Copy link
Contributor Author

I think this is more of a legacy. The feature was added later, and set to false to avoid breaking behaviours. But we could discuss if it should be default true, I agree with you on that.

@christophfroehlich christophfroehlich added CI and removed CI labels May 17, 2024
@christophfroehlich
Copy link
Contributor Author

Fixed with #1498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants