Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not repeat TriggerType enum in all hardware component classes #1958

Closed
saikishor opened this issue Dec 19, 2024 · 3 comments · Fixed by #1962
Closed

Do not repeat TriggerType enum in all hardware component classes #1958

saikishor opened this issue Dec 19, 2024 · 3 comments · Fixed by #1962
Assignees

Comments

@saikishor
Copy link
Member

I think it would be a good first issue to not repeat this enum in all classes right?

Originally posted by @bmagyar in #1567 (comment)

@kumar-sanjeeev
Copy link
Contributor

Hi @saikishor, I would like to work on this.

@saikishor
Copy link
Member Author

Hello @kumar-sanjeeev !

Thank you. I've assigned you the issue.

@kumar-sanjeeev
Copy link
Contributor

kumar-sanjeeev commented Dec 19, 2024

Thanks. I noticed that TriggerType enum is defined in two files within the include/hardware_interface directory i.e. system_interface.hpp and actuator_interface.hpp.I created a new file hardware_interface_trigger_type.hpp in the same directory to abstract this enum from the hardware component classes and raised the PR. If I missed something, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants