Extract robot description into global package (again) (#339) (#346)

* Use global rrbot_description in all examples * Move diffbot description to description package * Move r6bot into description package Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
ros-controls · Aug 17, 2023 · 66c2c23 · 66c2c23
1 parent f25bffd
commit 66c2c23
Show file tree

Hide file tree

Showing 100 changed files with 399 additions and 2,451 deletions.
diff --git a/example_1/CMakeLists.txt b/example_1/CMakeLists.txt
@@ -49,7 +49,7 @@ install(
   DESTINATION include/ros2_control_demo_example_1
 )
 install(
-  DIRECTORY description/launch description/ros2_control description/urdf description/rviz
+  DIRECTORY description/launch description/ros2_control description/urdf
   DESTINATION share/ros2_control_demo_example_1
 )
 install(

diff --git a/example_1/bringup/launch/rrbot.launch.py b/example_1/bringup/launch/rrbot.launch.py
@@ -61,7 +61,7 @@ def generate_launch_description():
         ]
     )
     rviz_config_file = PathJoinSubstitution(
-        [FindPackageShare("ros2_control_demo_example_1"), "rviz", "rrbot.rviz"]
+        [FindPackageShare("ros2_control_demo_description"), "rrbot/rviz", "rrbot.rviz"]
     )
 
     control_node = Node(

diff --git a/example_1/description/launch/view_robot.launch.py b/example_1/description/launch/view_robot.launch.py
@@ -27,7 +27,7 @@ def generate_launch_description():
     declared_arguments.append(
         DeclareLaunchArgument(
             "description_package",
-            default_value="ros2_control_demo_example_1",
+            default_value="ros2_control_demo_description",
             description="Description package with robot URDF/xacro files. Usually the argument \
         is not set, it enables use of a custom description.",
         )
@@ -69,7 +69,7 @@ def generate_launch_description():
             PathJoinSubstitution([FindExecutable(name="xacro")]),
             " ",
             PathJoinSubstitution(
-                [FindPackageShare(description_package), "urdf", description_file]
+                [FindPackageShare("ros2_control_demo_example_1"), "urdf", description_file]
             ),
             " ",
             "prefix:=",
@@ -79,7 +79,7 @@ def generate_launch_description():
     robot_description = {"robot_description": robot_description_content}
 
     rviz_config_file = PathJoinSubstitution(
-        [FindPackageShare(description_package), "rviz", "rrbot.rviz"]
+        [FindPackageShare(description_package), "rrbot/rviz", "rrbot.rviz"]
     )
 
     joint_state_publisher_node = Node(

diff --git a/example_1/description/urdf/rrbot.urdf.xacro b/example_1/description/urdf/rrbot.urdf.xacro
@@ -8,10 +8,10 @@ https://github.com/ros-simulation/gazebo_ros_demos/blob/kinetic-devel/rrbot_desc
   <xacro:arg name="prefix" default="" />
 
   <!-- Import RRBot macro -->
-  <xacro:include filename="$(find ros2_control_demo_example_1)/urdf/rrbot_description.urdf.xacro" />
+  <xacro:include filename="$(find ros2_control_demo_description)/rrbot/urdf/rrbot_description.urdf.xacro" />
 
   <!-- Import Rviz colors -->
-  <xacro:include filename="$(find ros2_control_demo_example_1)/urdf/rrbot.materials.xacro" />
+  <xacro:include filename="$(find ros2_control_demo_description)/rrbot/urdf/rrbot.materials.xacro" />
 
   <!-- Import RRBot ros2_control description -->
   <xacro:include filename="$(find ros2_control_demo_example_1)/ros2_control/rrbot.ros2_control.xacro" />

diff --git a/example_1/description/urdf/rrbot_description.urdf.xacro b/example_1/description/urdf/rrbot_description.urdf.xacro
diff --git a/example_1/doc/userdoc.rst b/example_1/doc/userdoc.rst
@@ -221,10 +221,10 @@ Files used for this demos
 * Controllers yaml: `rrbot_controllers.yaml <https://github.com/ros-controls/ros2_control_demos/tree/{REPOS_FILE_BRANCH}/example_1/bringup/config/rrbot_controllers.yaml>`__
 * URDF file: `rrbot.urdf.xacro <https://github.com/ros-controls/ros2_control_demos/tree/{REPOS_FILE_BRANCH}/example_1/description/urdf/rrbot.urdf.xacro>`__
 
-  * Description: `rrbot_description.urdf.xacro <https://github.com/ros-controls/ros2_control_demos/tree/{REPOS_FILE_BRANCH}/example_1/description/urdf/rrbot_description.urdf.xacro>`__
+  * Description: `rrbot_description.urdf.xacro <https://github.com/ros-controls/ros2_control_demos/tree/{REPOS_FILE_BRANCH}/ros2_control_demo_description/rrbot/urdf/rrbot_description.urdf.xacro>`__
   * ``ros2_control`` tag: `rrbot.ros2_control.xacro <https://github.com/ros-controls/ros2_control_demos/tree/{REPOS_FILE_BRANCH}/example_1/description/ros2_control/rrbot.ros2_control.xacro>`__
 
-* RViz configuration: `rrbot.rviz <https://github.com/ros-controls/ros2_control_demos/tree/{REPOS_FILE_BRANCH}/example_1/description/rviz/rrbot.rviz>`__
+* RViz configuration: `rrbot.rviz <https://github.com/ros-controls/ros2_control_demos/tree/{REPOS_FILE_BRANCH}/ros2_control_demo_description/rrbot/rviz/rrbot.rviz>`__
 * Test nodes goals configuration:
 
   + `rrbot_forward_position_publisher <https://github.com/ros-controls/ros2_control_demos/tree/{REPOS_FILE_BRANCH}/example_1/bringup/config/rrbot_forward_position_publisher.yaml>`__

diff --git a/example_1/package.xml b/example_1/package.xml
@@ -26,6 +26,7 @@
   <exec_depend>joint_state_publisher_gui</exec_depend>
   <exec_depend>joint_trajectory_controller</exec_depend>
   <exec_depend>robot_state_publisher</exec_depend>
+  <exec_depend>ros2_control_demo_description</exec_depend>
   <exec_depend>ros2_controllers_test_nodes</exec_depend>
   <exec_depend>ros2controlcli</exec_depend>
   <exec_depend>ros2launch</exec_depend>

diff --git a/example_12/CMakeLists.txt b/example_12/CMakeLists.txt
@@ -76,7 +76,7 @@ install(
   DESTINATION include/ros2_control_demo_example_12
 )
 install(
-  DIRECTORY description/launch description/ros2_control description/urdf description/gazebo description/rviz
+  DIRECTORY description/launch description/ros2_control description/urdf description/gazebo
   DESTINATION share/ros2_control_demo_example_12
 )
 install(

diff --git a/example_12/bringup/launch/rrbot.launch.py b/example_12/bringup/launch/rrbot.launch.py
@@ -47,7 +47,7 @@ def generate_launch_description():
         ]
     )
     rviz_config_file = PathJoinSubstitution(
-        [FindPackageShare("ros2_control_demo_example_12"), "rviz", "rrbot.rviz"]
+        [FindPackageShare("ros2_control_demo_description"), "rrbot/rviz", "rrbot.rviz"]
     )
 
     control_node = Node(

diff --git a/example_12/description/launch/view_robot.launch.py b/example_12/description/launch/view_robot.launch.py
@@ -26,7 +26,7 @@ def generate_launch_description():
     declared_arguments.append(
         DeclareLaunchArgument(
             "description_package",
-            default_value="ros2_control_demo_example_12",
+            default_value="ros2_control_demo_description",
             description="Description package with robot URDF/xacro files. Usually the argument \
         is not set, it enables use of a custom description.",
         )
@@ -59,7 +59,7 @@ def generate_launch_description():
             PathJoinSubstitution([FindExecutable(name="xacro")]),
             " ",
             PathJoinSubstitution(
-                [FindPackageShare(description_package), "urdf", description_file]
+                [FindPackageShare("ros2_control_demo_example_12"), "urdf", description_file]
             ),
             " ",
             "prefix:=",
@@ -69,7 +69,7 @@ def generate_launch_description():
     robot_description = {"robot_description": robot_description_content}
 
     rviz_config_file = PathJoinSubstitution(
-        [FindPackageShare(description_package), "rviz", "rrbot.rviz"]
+        [FindPackageShare(description_package), "rrbot/rviz", "rrbot.rviz"]
     )
 
     joint_state_publisher_node = Node(