🔧 use pre-commit workflow from ros2_control_ci (#458)

* Use new pre-commit wf from ros2_control_ci

* Update pre-commit config

* Fix license text in contributing.md

* Add update-pre-commit

(cherry picked from commit 7dc41df)

# Conflicts:
#	.github/workflows/ci-ros-lint.yml

.github/workflows/humble-pre-commit.yml

@@ -0,0 +1,14 @@
+name: Pre-Commit - Humble
+
+on:
+ workflow_dispatch:
+ pull_request:
+ branches:
+ - humble
+
+jobs:
+ pre-commit:
+ uses: ros-controls/ros2_control_ci/.github/workflows/reusable-pre-commit.yml@master
+ with:
+ ros_distro: humble
+ os_name: ubuntu-22.04

.github/workflows/iron-pre-commit.yml

@@ -0,0 +1,14 @@
+name: Pre-Commit - Iron
+
+on:
+ workflow_dispatch:
+ pull_request:
+ branches:
+ - iron
+
+jobs:
+ pre-commit:
+ uses: ros-controls/ros2_control_ci/.github/workflows/reusable-pre-commit.yml@master
+ with:
+ ros_distro: iron
+ os_name: ubuntu-22.04

.github/workflows/rolling-pre-commit.yml

@@ -0,0 +1,14 @@
+name: Pre-Commit - Rolling
+
+on:
+ workflow_dispatch:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ pre-commit:
+ uses: ros-controls/ros2_control_ci/.github/workflows/reusable-pre-commit.yml@master
+ with:
+ ros_distro: rolling
+ os_name: ubuntu-22.04

.github/workflows/update-pre-commit.yml

@@ -0,0 +1,12 @@
+name: Auto Update pre-commit
+# Update pre-commit config and create PR if changes are detected
+# author: Christoph Fröhlich <christoph.froehlich@ait.ac.at>
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 0 * * 0' # Run every Sunday at midnight
+
+jobs:
+ auto_update_and_create_pr:
+ uses: ros-controls/ros2_control_ci/.github/workflows/reusable-update-pre-commit.yml@master

.pre-commit-config.yaml

@@ -1,3 +1,4 @@
+
 # To use:
 #
 # pre-commit run -a
@@ -15,7 +16,7 @@
 repos:
  # Standard hooks
  - repo: https://github.com/pre-commit/pre-commit-hooks
- rev: v4.4.0
+ rev: v4.5.0
  hooks:
  - id: check-added-large-files
  - id: check-ast
@@ -29,68 +30,57 @@ repos:
  - id: end-of-file-fixer
  - id: mixed-line-ending
  - id: trailing-whitespace
+ exclude_types: [rst]
  - id: fix-byte-order-marker
 
+
  # Python hooks
  - repo: https://github.com/asottile/pyupgrade
- rev: v3.3.1
+ rev: v3.15.1
  hooks:
  - id: pyupgrade
  args: [--py36-plus]
 
- - repo: https://github.com/psf/black
- rev: 22.12.0
- hooks:
- - id: black
- args: ["--line-length=99"]
-
  # PyDocStyle
  - repo: https://github.com/PyCQA/pydocstyle
- rev: 6.2.3
+ rev: 6.3.0
  hooks:
  - id: pydocstyle
  args: ["--ignore=D100,D101,D102,D103,D104,D105,D106,D107,D203,D212,D404"]
 
+ - repo: https://github.com/psf/black
+ rev: 24.2.0
+ hooks:
+ - id: black
+ args: ["--line-length=99"]
+
  - repo: https://github.com/pycqa/flake8
- rev: 6.0.0
+ rev: 7.0.0
  hooks:
  - id: flake8
- args: ["--ignore=E501"]
+ args: ["--extend-ignore=E501"]
 
  # CPP hooks
- - repo: local
+ - repo: https://github.com/pre-commit/mirrors-clang-format
+ rev: v17.0.6
  hooks:
  - id: clang-format
- name: clang-format
- description: Format files with ClangFormat.
- entry: clang-format-14
- language: system
- files: \.(c|cc|cxx|cpp|frag|glsl|h|hpp|hxx|ih|ispc|ipp|java|js|m|proto|vert)$
  args: ['-fallback-style=none', '-i']
- # The same options as in ament_cppcheck are used, but its not working...
- #- repo: https://github.com/pocc/pre-commit-hooks
- #rev: v1.1.1
- #hooks:
- #- id: cppcheck
- #args: ['--error-exitcode=1', '-f', '--inline-suppr', '-q', '-rp', '--suppress=internalAstError', '--suppress=unknownMacro', '--verbose']
 
  - repo: local
  hooks:
  - id: ament_cppcheck
  name: ament_cppcheck
  description: Static code analysis of C/C++ files.
- stages: [commit]
- entry: ament_cppcheck
+ entry: env AMENT_CPPCHECK_ALLOW_SLOW_VERSIONS=1 ament_cppcheck
  language: system
  files: \.(h\+\+|h|hh|hxx|hpp|cuh|c|cc|cpp|cu|c\+\+|cxx|tpp|txx)$
 
- # Maybe use https://github.com/cpplint/cpplint instead
  - repo: local
  hooks:
  - id: ament_cpplint
  name: ament_cpplint
  description: Static code analysis of C/C++ files.
- stages: [commit]
  entry: ament_cpplint
  language: system
  files: \.(h\+\+|h|hh|hxx|hpp|cuh|c|cc|cpp|cu|c\+\+|cxx|tpp|txx)$
@@ -102,7 +92,6 @@ repos:
  - id: ament_lint_cmake
  name: ament_lint_cmake
  description: Check format of CMakeLists.txt files.
- stages: [commit]
  entry: ament_lint_cmake
  language: system
  files: CMakeLists\.txt$
@@ -113,7 +102,6 @@ repos:
  - id: ament_copyright
  name: ament_copyright
  description: Check if copyright notice is available in all files.
- stages: [commit]
  entry: ament_copyright
  language: system
 
@@ -126,7 +114,7 @@ repos:
  exclude: CHANGELOG\.rst$
 
  - repo: https://github.com/pre-commit/pygrep-hooks
- rev: v1.9.0
+ rev: v1.10.0
  hooks:
  - id: rst-backticks
  exclude: CHANGELOG\.rst$
@@ -136,8 +124,18 @@ repos:
  # Spellcheck in comments and docs
  # skipping of *.svg files is not working...
  - repo: https://github.com/codespell-project/codespell
- rev: v2.2.2
+ rev: v2.2.6
  hooks:
  - id: codespell
  args: ['--write-changes']
- exclude: \.(svg|pyc)$
+ exclude: CHANGELOG\.rst|\.(svg|pyc)$
+
+ - repo: https://github.com/python-jsonschema/check-jsonschema
+ rev: 0.28.0
+ hooks:
+ - id: check-github-workflows
+ args: ["--verbose"]
+ - id: check-github-actions
+ args: ["--verbose"]
+ - id: check-dependabot
+ args: ["--verbose"]

CONTRIBUTING.md

@@ -50,7 +50,9 @@ As this project, by default, uses the default GitHub issue labels
 
 
 ## Licensing
-Any contribution that you make to this repository will be under the Apache 2 License, as dictated by that [license]:
+Any contribution that you make to this repository will
+be under the Apache 2 License, as dictated by that
+[license](http://www.apache.org/licenses/LICENSE-2.0.html):
 
 ~~~
 5. Submission of Contributions. Unless You explicitly state otherwise,